From bda5726650b18edea367db0fb16a29b9e711e3e2 Mon Sep 17 00:00:00 2001 From: Oskar Haarklou Veileborg Date: Thu, 12 Jan 2023 11:00:26 +0100 Subject: [PATCH] Fix random seed for TestRandom The closure passed to t.Run captured the loop variable which would always be equal to `*randomN` once the tests started running. This meant that all of the runs used the same random seed. --- immutable_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/immutable_test.go b/immutable_test.go index 9a0de37..581d4d8 100644 --- a/immutable_test.go +++ b/immutable_test.go @@ -2495,6 +2495,7 @@ func RunRandom(t *testing.T, name string, fn func(t *testing.T, rand *rand.Rand) } t.Run(name, func(t *testing.T) { for i := 0; i < *randomN; i++ { + i := i t.Run(fmt.Sprintf("%08d", i), func(t *testing.T) { t.Parallel() fn(t, rand.New(rand.NewSource(int64(i))))