Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue30Test uses incorrect date time format pattern #1788

Closed
Marcono1234 opened this issue Oct 26, 2024 · 4 comments · Fixed by #1789
Closed

Issue30Test uses incorrect date time format pattern #1788

Marcono1234 opened this issue Oct 26, 2024 · 4 comments · Fixed by #1789

Comments

@Marcono1234
Copy link
Contributor

  • h is 'clock-hour-of-am-pm (1-12)', without am/pm marker (a) this might not be intended
    Should maybe be H ('hour-of-day (0-23)')?
  • M is 'month-of-year'
    Should probably be m ('minute-of-hour')

So the pattern should probably be: HH:mm:ss.SSS

If this won't require signing the CLA, I can submit a pull request for this. Otherwise it might be easier if you fix this incorrect pattern.

@ben-manes
Copy link
Owner

No cla required (which just reiterates its Apache license). PRs welcome

@Marcono1234
Copy link
Contributor Author

No cla required

Generally not, or only not for this small fix? Because currently there is CLAassistant set up for this repository, and CONTRIBUTING.md mentions it as well.

@ben-manes
Copy link
Owner

It is there to encourage an explicit agreement of the Apache license instead of an implicit one through the act of contributing. We use the ASF’s which they consider optional. Unlike CLAs that reassign ownership, the ASF’s is record keeping of the notice as it reiterates the license. When devs feel the need to get lawyer approval for any contribution, this clarifies that there are no extra side agreements to the license. Typically they just send a new CLA for me to sign which reasserts that because that because that is their process assuming no CLA.

For me it’s just a checklist item for community health, like OSSF’s, which are becoming the norm. There’s not much direct value, but it makes non-technical groups feel respected when topics raise to their awareness.

@ben-manes
Copy link
Owner

Are contributors' employers required to sign a CCLA?
...
The CCLA is a backup document that the committer/ICLA signer may use to eliminate all of the ambiguity between conflicting laws, contracts, policies and job assignments. We've never required it. Many committers are confident of their individual representations under the ICLA, many other committers find it reassuring that their company has backed up their own ICLA with this umbrella document.

https://www.apache.org/licenses/cla-faq.html#cclas-not-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants