-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue30Test
uses incorrect date time format pattern
#1788
Comments
No cla required (which just reiterates its Apache license). PRs welcome |
Generally not, or only not for this small fix? Because currently there is CLAassistant set up for this repository, and |
It is there to encourage an explicit agreement of the Apache license instead of an implicit one through the act of contributing. We use the ASF’s which they consider optional. Unlike CLAs that reassign ownership, the ASF’s is record keeping of the notice as it reiterates the license. When devs feel the need to get lawyer approval for any contribution, this clarifies that there are no extra side agreements to the license. Typically they just send a new CLA for me to sign which reasserts that because that because that is their process assuming no CLA. For me it’s just a checklist item for community health, like OSSF’s, which are becoming the norm. There’s not much direct value, but it makes non-technical groups feel respected when topics raise to their awareness. |
https://www.apache.org/licenses/cla-faq.html#cclas-not-required |
caffeine/caffeine/src/test/java/com/github/benmanes/caffeine/cache/issues/Issue30Test.java
Line 154 in 0eaf6f2
h
is 'clock-hour-of-am-pm (1-12)', without am/pm marker (a
) this might not be intendedShould maybe be
H
('hour-of-day (0-23)')?M
is 'month-of-year'Should probably be
m
('minute-of-hour')So the pattern should probably be:
HH:mm:ss.SSS
If this won't require signing the CLA, I can submit a pull request for this. Otherwise it might be easier if you fix this incorrect pattern.
The text was updated successfully, but these errors were encountered: