Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that compilation errors surface properly when building a project with CSharpier.msbuild in debug #959

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Ensure that compilation errors surface properly when building a project with CSharpier.msbuild in debug #959

merged 4 commits into from
Sep 25, 2023

Conversation

belav
Copy link
Owner

@belav belav commented Sep 10, 2023

closes #957

shocklateboy92
shocklateboy92 reviewed Sep 16, 2023
View reviewed changes
Copy link
Collaborator

@shocklateboy92 shocklateboy92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, I realized my comment was still pending

Src/CSharpier.MsBuild/build/CSharpier.MsBuild.targets Outdated Show resolved Hide resolved
@shocklateboy92 shocklateboy92 enabled auto-merge (squash) September 25, 2023 00:10
@shocklateboy92 shocklateboy92 merged commit 8c6a3b1 into main Sep 25, 2023
3 checks passed
@shocklateboy92 shocklateboy92 deleted the msbuild-compile-errors branch September 25, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shocklateboy92 shocklateboy92 shocklateboy92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@belav @shocklateboy92