-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break InvocationExpression chain before breaking ArguementList #451
Labels
Comments
Probably related // breaking after the = makes this look better
var cbTempSubkeys =
checked(_symmetricAlgorithmSubkeyLengthInBytes + _hmacAlgorithmSubkeyLengthInBytes);
// but then this looks better with checked next to =
var cbEncryptedData = checked(
cbCiphertext
- (
KEY_MODIFIER_SIZE_IN_BYTES
+ _symmetricAlgorithmBlockSizeInBytes
+ _hmacAlgorithmDigestLengthInBytes
)
); |
This was referenced Oct 19, 2021
Closed
httpContext.Response.Headers[
HeaderNames.XFrameOptions
] = "SAMEORIGIN1111111111111111111111";
// should be
httpContext.Response.Headers[HeaderNames.XFrameOptions]
= "SAMEORIGIN1111111111111111111111"; |
These all need to end up consistent too var someLongValue_________________ = memberAccessExpression[
elementAccessExpression
].theMember______________________________;
var someLongValue_________________ = memberAccessExpression[
elementAccessExpression
].theMember______________________________();
var someLongValue_________________ = memberAccessExpression(
elementAccessExpression
).theMember______________________________;
var someLongValue_________________ = memberAccessExpression(elementAccessExpression)
.theMember______________________________(); |
some more examples var node = FindToken(span.Start, findInsideTrivia).Parent.FirstAncestorOrSelf(
(a, span) => a.FullSpan.Contains(span),
span
);
var node = FindToken(span.Start, findInsideTrivia)
.Parent()
.FirstAncestorOrSelf((a, span) => a.FullSpan.Contains(span), span); |
This is semi-related
|
Related, we should abide by the rectangle rule in these situations ValueProviderResult valueProviderResult = bindingContext
.ValueProvider
.GetValue(bindingContext.ModelName);
// vs
ValueProviderResult valueProviderResult =
bindingContext.ValueProvider.GetValue(bindingContext.ModelName);
ValueProviderResult valueProviderResult = bindingContext
.ValueProvider
.SomeLongProperty____________________
.GetValue(bindingContext.ModelName);
// vs
ValueProviderResult valueProviderResult =
bindingContext
.ValueProvider
.SomeLongProperty____________________
.GetValue(bindingContext.ModelName); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This prettier PR may help - https://github.com/prettier/prettier/pull/8063/files
These are a number of examples.
But if we know the ArgumentList will break, I think this is preferred
The text was updated successfully, but these errors were encountered: