Skip to content
This repository has been archived by the owner on Jan 25, 2025. It is now read-only.

Add some constants for use in Toga. #5

Merged
merged 2 commits into from
Aug 18, 2018
Merged

Add some constants for use in Toga. #5

merged 2 commits into from
Aug 18, 2018

Conversation

rayrrr
Copy link
Contributor

@rayrrr rayrrr commented Jul 18, 2018 •
edited
Loading

These constants really belong in Travertino, not Toga

See beeware/toga#563

This was referenced Jul 18, 2018
Merged
Closed
freakboy3742
freakboy3742 suggested changes Jul 21, 2018
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these changes make sense, but pack in particular shouldn't be in Travertino. Row/Column, Visible/Hidden and None are all generic concepts; but Pack is a very specific concept in Toga's Pack algorithm.

@rayrrr
Copy link
Contributor Author

rayrrr commented Jul 21, 2018 •
edited
Loading

@freakboy3742 I removed PACK from Travertino and put it back in Toga like you asked. Thanks!

@freakboy3742 freakboy3742 merged commit dfb88c5 into beeware:master Aug 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayrrr @freakboy3742