Skip to content
This repository has been archived by the owner on Jan 25, 2025. It is now read-only.

Add pre commit, and applied other project configuration updates #34

Merged
merged 7 commits into from
Feb 16, 2023

Conversation

freakboy3742
Copy link
Member

@freakboy3742 freakboy3742 commented Feb 15, 2023

  • Adds a pre-commit configuration (thereby applying black to the codebase)
  • Moves to a full PEP517 project config
  • Adopts setuptools_scm version numbering
  • Modifies the CI pipeline to test pre-build CI packages.
  • Adds a note on pre-commit and towncrier to the README, to help new contributors get onboarded.

Fixes #18.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 requested a review from mhsmith February 15, 2023 04:30
pyproject.toml Outdated
"setuptools >= 43.0.0",
"wheel >= 0.32.0",
]
requires = ["setuptools>=60", "setuptools_scm[toml]>=7.0"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reproducibility, I think it's better for this section to pin exact version numbers, as I did in Toga.

@freakboy3742 freakboy3742 requested a review from mhsmith February 16, 2023 00:10
@mhsmith mhsmith merged commit 848850a into main Feb 16, 2023
@freakboy3742 freakboy3742 deleted the pre-commit branch February 17, 2023 06:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Towncrier short explanation should be in CONTRIBUTING.md
2 participants