Skip to content
This repository has been archived by the owner on Jan 25, 2025. It is now read-only.

Color validations #17

Merged
merged 4 commits into from
Apr 30, 2020
Merged

Color validations #17

merged 4 commits into from
Apr 30, 2020

Conversation

saroad2
Copy link
Member

@saroad2 saroad2 commented Apr 29, 2020

Add color constructor validations in order to make sure that rgb and hsl objects are constructed with valid values.

@saroad2
Copy link
Member Author

saroad2 commented Apr 29, 2020

This PR fail on towncrier.check. I'm not sure what the right thing to do in order to fix the error. Just run towncrier?

@freakboy3742
Copy link
Member

Towncrier is a recent addition; it's a way of making sure that our release notes stay up to date. It ensures that every pull request that is merged must have a release note describing the feature/bug/etc that the PR implements.

The test will pass if there is a single new file in the changes folder with the name 17.bug.rst (or 17.feature.rst for a new feature, or 17.doc.rst for new docs, or 17.removal.rst for a feature that has been removed, or 17.misc.rst for miscellaneous admin that isn't release note worthy). You don't need to run anything; you only need to add a file to the changes directory.

@saroad2
Copy link
Member Author

saroad2 commented Apr 29, 2020

On it 👍

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like solid changes.

The tests are all good, but they really do have me pining for pytest parametrization... That's no reason to block on this PR, but it's yet another reason to start making that change.

@freakboy3742 freakboy3742 merged commit cecbca9 into beeware:master Apr 30, 2020
@saroad2 saroad2 deleted the color_validations branch May 1, 2020 06:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants