Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cascading windows #2620

Merged
merged 9 commits into from
Jun 12, 2024
Merged

Cascading windows #2620

merged 9 commits into from
Jun 12, 2024

Conversation

freakboy3742
Copy link
Member

@freakboy3742 freakboy3742 commented Jun 7, 2024

Derived from #2244.

Ensure that each new window gets a new position, cascaded from the previous window with a default position.

Also splits the window testbed tests into 2 modules, making it easier to run the window size/position tests without also running the longer dialog tests.

Fixes #2023.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 requested a review from mhsmith June 7, 2024 07:13
@mhsmith
Copy link
Member

mhsmith commented Jun 11, 2024

Also splits the window testbed tests into 2 modules, making it easier to run the window size/position tests without also running the longer dialog tests.

This can also be achieved with a pytest flag like -k "not dialog". But in this case the split makes sense anyway, because dialogs are a large and self-contained group of tests.

@mhsmith mhsmith merged commit 3c51620 into beeware:main Jun 12, 2024
31 of 34 checks passed
@freakboy3742 freakboy3742 deleted the cascading-windows branch June 12, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cascading windows
2 participants