Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete implementation and testing of DocumentApp #2209

Closed
mhsmith opened this issue Nov 8, 2023 · 1 comment · Fixed by #2666
Closed

Complete implementation and testing of DocumentApp #2209

mhsmith opened this issue Nov 8, 2023 · 1 comment · Fixed by #2666
Labels
enhancement New features, or improvements to existing features.

Comments

@mhsmith
Copy link
Member

mhsmith commented Nov 8, 2023

What is the problem or limitation you are having?

DocumentApp is currently implemented on Cocoa and GTK, but not covered by the testbed. On WinForms it's not really implemented at all.

Describe the solution you'd like

All three platforms should implement the API, with as much automated testbed coverage as possible.

@mhsmith mhsmith added the enhancement New features, or improvements to existing features. label Nov 8, 2023
@freakboy3742
Copy link
Member

In case anyone wants to look into this: testing will almost certainly require a second testbed app, or at least a significant workflow change in the existing testbed app that creates a second app after the first one has exited. If a second app is used, there needs to be a way to merge coverage between two apps - which isn't a problem on desktop platforms, but will be complicated on mobile.

In terms of functionality - this works well on Cocoa, but it's a little hazy on GTK because it's not clear whether a single app instance can/should be allowed to open multiple documents. It's currently documented as "one app, one doc"; but the implementation has some edge cases that allow for multiple documents to be opened (Start the document app without nominating a document - you get a file dialog. This lets you open a document... but also preserves the original window so you can open another one. Both windows honor CTRL-O, which opens a new window). Part of the work to be done here is to resolve what the correct native interpretation of a document-based app should be on GTK (and, for that matter, Windows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features, or improvements to existing features.
Projects
None yet
2 participants