Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button / select box - font size attribute #1037

Closed
AndiLeni opened this issue Sep 3, 2020 · 2 comments
Closed

Button / select box - font size attribute #1037

AndiLeni opened this issue Sep 3, 2020 · 2 comments
Labels
bug A crash or error in behavior. windows The issue relates to Microsoft Windows support.

Comments

@AndiLeni
Copy link

AndiLeni commented Sep 3, 2020

Describe the bug
font_size attribute is not working for buttons and select boxes.

To Reproduce

button = toga.Button(
            'Eintrag speichern',
            on_press=self.say_hello,
            style=Pack(padding=5, font_size=15)
        )

or
toga.Selection(items=['m', 'w'], style=Pack(font_size=15))

Expected behavior
The font size should change.

Screenshots
/

Environment:

  • Operating System: windows 10
  • Python version: 3.8.5
  • Software versions:
    • Briefcase: 0.3.3
    • toga-core==0.3.0.dev22
    • toga-winforms==0.3.0.dev22

Additional context
/

@AndiLeni AndiLeni added the bug A crash or error in behavior. label Sep 3, 2020
@AndiLeni AndiLeni changed the title Button font size Button / select box - font size attribute Sep 3, 2020
@freakboy3742 freakboy3742 added up-for-grabs windows The issue relates to Microsoft Windows support. bug A crash or error in behavior. and removed bug A crash or error in behavior. labels Mar 29, 2022
@shape-warrior-t
Copy link
Contributor

shape-warrior-t commented Jul 28, 2022

I've been looking into this issue. As of now, on Windows, font_size works for buttons, but not select boxes. The same thing also happens to be true for Android, based on my testing.

I'll try and see if there's anything I can do to quickly fix this bug.

EDIT: Taking a quick look at the source code for other platforms, I can't identify any functions for setting fonts on any of them. So I suspect that select boxes simply don't support setting the font as of right now.

@freakboy3742
Copy link
Member

#1761 Addressed this issue, and added runtime tests of this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A crash or error in behavior. windows The issue relates to Microsoft Windows support.
Projects
None yet
Development

No branches or pull requests

3 participants