-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize template for GUI framework plugins #82
Conversation
2fc0b99
to
9f74ece
Compare
bfcb075
to
748b541
Compare
748b541
to
7f2a0d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly straightforward stuff, subject to the changes in the matching Briefcase PR. Only major issue is about testing strategy; details inline.
requirements.txt
Outdated
pre-commit ==3.5.0 | ||
pytest ==7.4.3 | ||
toml ==0.10.2 | ||
tox ==4.11.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly odd whitespace usage here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was inspired by the way that these constraints are interpreted by the packaging infrastructure such that the operator is really a part of the version.
>>> from packaging.requirements import Requirement
>>> str(Requirement("toga == 0.4.0").specifier)
'==0.4.0'
>>> str(Requirement("toga >= 0.4.0, < 1").specifier)
'<1,>=0.4.0'
But I should make them consistent with the rest of our dependency specifications.
tests/test_app_template.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this test is validating what it once did. Previously, it was a check that the code generated by the template was actually valid, and passes flake8; however, now, it's doing those checks mostly on values that have been provided by the test itself. All the interesting logic that needs validation is in the Briefcase repo now.
A briefcase new --noinput && briefcase build
check is probably called for to ensure the template is actually valid and results in compilable content; but beyond that, the place we need to test this is in Briefcase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah; that's something I've been struggling with for these changes. I have a similar comment in beeware/briefcase#1524.
I think the tests here are still relevant as-is, though....since the template itself does have some control over creating a valid project....as I've learned by having to seemingly endlessly tweak the jinja2 templating to play nicely.
We can consider the broader testing strategy in beeware/briefcase#1524.
826a8cc
to
6f22fbc
Compare
fda1d64
to
0fa3272
Compare
0fa3272
to
53132b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One error found in the template, but otherwise this looks good to go once the repo reference is updated.
] | ||
{{- cookiecutter.pyproject_table_windows }} | ||
{% endif %} | ||
{% if cookiecutter.pyproject_table_macOS or cookiecutter.pyproject_table_android %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be iOS, not macOS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep; thought I got em all. Thanks.
19c57b1
to
27740ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as approved, conditional on changes that are needed as part of the beeware/briefcase#1524 landing strategy
ea8b3aa
to
2d90800
Compare
2d90800
to
a76c95e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for final ship
Changes
BRIEFCASE_REPO: https://github.com/rmartin16/briefcase
BRIEFCASE_REF: run-app-in-ci-testing
PR Checklist: