Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove testing apps since CI will generate them now; disable PySide2 testing #45

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Remove testing apps since CI will generate them now; disable PySide2 testing #45

merged 2 commits into from
Nov 18, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Nov 17, 2023 •
edited
Loading

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 mentioned this pull request Nov 17, 2023
Merged
4 tasks
freakboy3742
freakboy3742 requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for the required.github update.

@rmartin16 rmartin16 marked this pull request as ready for review November 17, 2023 23:30
@freakboy3742 freakboy3742 merged commit 702b88c into beeware:main Nov 18, 2023
20 checks passed
@rmartin16 rmartin16 deleted the ci branch November 18, 2023 02:12
@rmartin16 rmartin16 mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmartin16 @freakboy3742