Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled Travis tests for HHVM #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Enabled Travis tests for HHVM #8

wants to merge 4 commits into from

Conversation

JanPetterMG
Copy link
Contributor

No description provided.

@JanPetterMG
Copy link
Contributor Author

This library contains an unrelated bug witch causes every single test to fail, no matter what PHP version it's been tested on. Whoever wrote the failing test should also fix it.

From Travis:

PHP Fatal error: Class Bee4\Test\FakeDispatcher contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods (Bee4\Events\DispatcherInterface::on, Bee4\Events\DispatcherInterface::once) in /home/travis/build/bee4/transport/test/units/FakeDispatcher.php on line 21

@shulard
Copy link
Member

shulard commented Jun 28, 2016

Hello I've checked that bug about FakeDispatcher and I've updated the code, the build must pass now. Thanks for that PR 😄

@shulard
Copy link
Member

shulard commented Jun 28, 2016

Can you rebase your PR on the latest master version ?

@shulard shulard self-assigned this Jun 28, 2016
@JanPetterMG
Copy link
Contributor Author

10 errors thrown.
https://travis-ci.org/bee4/transport/jobs/140866474

Bee4\Transport\Exception\CurlException: couldn't connect to host

Travis now accepts failures for HHVM, witch is why the build doesn't fail...

@shulard
Copy link
Member

shulard commented Jun 28, 2016

Thanks for the update ! I think the error is related to the use of php built in server during the test process. I don't know HHVM enough for the moment to handle that part... Do you know if there is that kind of behaviour in HHVM to ?

@shulard shulard force-pushed the master branch 3 times, most recently from 585cc52 to 87c4944 Compare June 30, 2016 08:05
@shulard
Copy link
Member

shulard commented Jun 30, 2016

I've started a new branch about HHVM support but can't get this working, if you have experience with the hhvm built-in server please help : https://github.com/bee4/transport/tree/feature/hhvm

@JanPetterMG
Copy link
Contributor Author

Thanks for the update. It will probably take a few days before I have the time to look at it, but I'll see what I can do. Stay tuned.

@shulard shulard added the hard label Jul 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants