Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] When the plaintext has significant invisible characters alert the user #134

Open
bee-san opened this issue Dec 10, 2022 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@bee-san
Copy link
Owner

bee-san commented Dec 10, 2022

Currently we print to the terminal which may obscure invisible characters. I propose that when the plaintext is made up of 20 or 30% invisible characters we alert the user with something like:

❓ 41% of the plaintext is invisible characters, would you like to save to a file instead? (y/N)
y

Please enter a filename: (default: $HOME/ares_text.txt)
@bee-san bee-san added the bug Something isn't working label Dec 10, 2022
@bee-san
Copy link
Owner Author

bee-san commented Dec 11, 2022

We should also offer the ability to write to a file if the output is of a certain length (I'd say maybe 100 chars!)

@bee-san bee-san added the good first issue Good for newcomers label Dec 26, 2022
@RenTrieu
Copy link

Hello, I was interested in working on this issue. Is this still available to work on?

@gregorni
Copy link
Contributor

gregorni commented Jan 3, 2024

@RenTrieu I haven't seen any active development by the maintainers of this repo in the last 5 months, so I'm not sure your pull request will be reviewed if you open one. You can still try if you think it'll be worth it for you.

On that note, @bee-san @SkeletalDemise Has something happened that this repository hasn't been update in such a long time? It was quite active when I last contributed.

@bee-san
Copy link
Owner Author

bee-san commented Jan 3, 2024

Oh I forgot to reply, it's xmas :) It will be reviewed, all pull requests are reviewd.

The CI cargo deny issues are in the realm of @SkeletalDemise , who knows way more about cargo deny than i do :( It may be easier to just rip the whole thing out rather than fix it.

@RenTrieu feel free to contribute a PR!

We have a Discord we talk in quite a lot http://discord.skerritt.blog

@RenTrieu
Copy link

RenTrieu commented Jan 4, 2024

Sounds good! I'll get working on the issue. I look forward to making a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants