-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] When the plaintext has significant invisible characters alert the user #134
Comments
We should also offer the ability to write to a file if the output is of a certain length (I'd say maybe 100 chars!) |
Hello, I was interested in working on this issue. Is this still available to work on? |
@RenTrieu I haven't seen any active development by the maintainers of this repo in the last 5 months, so I'm not sure your pull request will be reviewed if you open one. You can still try if you think it'll be worth it for you. On that note, @bee-san @SkeletalDemise Has something happened that this repository hasn't been update in such a long time? It was quite active when I last contributed. |
Oh I forgot to reply, it's xmas :) It will be reviewed, all pull requests are reviewd. The CI cargo deny issues are in the realm of @SkeletalDemise , who knows way more about cargo deny than i do :( It may be easier to just rip the whole thing out rather than fix it. @RenTrieu feel free to contribute a PR! We have a Discord we talk in quite a lot http://discord.skerritt.blog |
Sounds good! I'll get working on the issue. I look forward to making a PR! |
Currently we print to the terminal which may obscure invisible characters. I propose that when the plaintext is made up of 20 or 30% invisible characters we alert the user with something like:
The text was updated successfully, but these errors were encountered: