Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] When we return to the API, do not vectorise the result #130

Open
bee-san opened this issue Dec 7, 2022 · 0 comments
Open

[BUG] When we return to the API, do not vectorise the result #130

bee-san opened this issue Dec 7, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@bee-san
Copy link
Owner

bee-san commented Dec 7, 2022

/// // The result is an Option<DecoderResult> so we need to unwrap it
/// // The DecoderResult contains the text and the path
/// // The path is a vector of CrackResults which contains the decoder used and the keys used
/// // The text is a vector of strings because some decoders return more than 1 text (Caesar)
/// // Becuase the program has returned True, the first result is the plaintext (and it will only have 1 result).
/// // This is some tech debt we need to clean up
/// assert!(result.unwrap().text[0] == "The main function to call which performs the cracking.");

We should instead just return the text without a vector, or we should look at using this vector to store an array of answers for #129

@bee-san bee-san added the bug Something isn't working label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant