Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Technical debt] Ares uses strings instead of bytes for everything #121

Open
SkeletalDemise opened this issue Dec 5, 2022 · 1 comment
Labels
enhancement New feature or request Technical Debt A conscious decision we have made to reach our goals faster which has resulted in technical debt

Comments

@SkeletalDemise
Copy link
Collaborator

Ares currently uses strings in decoders, checkers, and the searcher. This causes a problem when attempting to add support for modern encryption like XOR as results will not be in UTF-8 strings but bytes.

Furthermore Ares should not assume that results from decoders will be in UTF-8. They could be in other encodings like UTF-16, UTF-32, etc.

The solution is to refactor Ares to use bytes for everything. This will allow us to implement modern encryption like XOR, AES, DES, etc. and support for other text encodings.

@SkeletalDemise SkeletalDemise added enhancement New feature or request Technical Debt A conscious decision we have made to reach our goals faster which has resulted in technical debt labels Dec 5, 2022
@SkeletalDemise
Copy link
Collaborator Author

This also prevents us from implementing decompressors for Deflate, Gzip, LZMA, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Technical Debt A conscious decision we have made to reach our goals faster which has resulted in technical debt
Projects
None yet
Development

No branches or pull requests

1 participant