Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal - New external package - rebased #426

Open
TimothyStiles opened this issue Dec 12, 2023 · 2 comments
Open

Proposal - New external package - rebased #426

TimothyStiles opened this issue Dec 12, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed intermediate Will take some time to fix medium priority The default priority for a new issue. stale

Comments

@TimothyStiles
Copy link
Collaborator

Describe the desired feature/enhancement

For a while we've had this really great parser for NEB's enzyme cut site database rebase.

Is your feature request related to a problem?

It can be difficult looking up these enzymes and inputting their data manually for simulating digests. Right now we have a couple of common ones available but it'd be better to have have a more expansive solution.

Describe the solution you'd like

I want to be able to access rebase programmatically for arbitrary enzymes. We haven't manually added rebase because of possible git repo size ballooning.

The ways I could see this being done are:

  1. Including a "download" function in poly that downloads the database for the user into their project to be handled manually.
  2. Create a minimal go package that are just predefined enzyme structs based on rebase. We could have a GH action to auto-update the package on a new rebase release and maybe force push an overwriting update so we don't end up making a huge git repo over time.
@TimothyStiles TimothyStiles added enhancement New feature or request needs-triage An issue that needs to be triaged help wanted Extra attention is needed medium priority The default priority for a new issue. labels Dec 12, 2023
@carreter carreter added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Dec 12, 2023
@TimothyStiles TimothyStiles changed the title Proposal - New external packaged - rebased Proposal - New external package - rebased Dec 12, 2023
@carreter
Copy link
Collaborator

I'm personally a fan of 2, as it means that binaries don't need to access the internet to use the database but our repo stays small.

Maybe we make it so that the external repo is for dumping all of the external DBs we might want our users to have access to that aren't a part of core functionality? Something like: bebop/poly-data?

@carreter carreter added intermediate Will take some time to fix and removed needs-triage An issue that needs to be triaged labels Dec 14, 2023
Copy link

This issue has had no activity in the past 2 months. Marking as stale.

@github-actions github-actions bot added the stale label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed intermediate Will take some time to fix medium priority The default priority for a new issue. stale
Projects
None yet
Development

No branches or pull requests

2 participants