You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like to make this consistent across all assertions, in the following manner:
For every assertion, every argument between the asserted value and the message is part of the $constraints array, passed to the exception.
Please let me know if you'd consider this, then I'll make a PR for it.
The text was updated successfully, but these errors were encountered:
I've noticed that not all assertions pass their constraints to the exception, for instance:
eq
has the expected value passed to the exception:assert/lib/Assert/Assertion.php
Lines 305 to 313 in c07fe16
greaterThan
on the other hand, has not:assert/lib/Assert/Assertion.php
Lines 2074 to 2082 in c07fe16
I would like to make this consistent across all assertions, in the following manner:
For every assertion, every argument between the asserted value and the message is part of the
$constraints
array, passed to the exception.Please let me know if you'd consider this, then I'll make a PR for it.
The text was updated successfully, but these errors were encountered: