Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Beautifier: breaks :before and :after (regression) #339

Closed
Infocatcher opened this issue Oct 19, 2013 · 5 comments
Closed

CSS Beautifier: breaks :before and :after (regression) #339

Infocatcher opened this issue Oct 19, 2013 · 5 comments

Comments

@Infocatcher
Copy link
Contributor

Regression in 27b65a5 commit.
Testcase:

<style>
.addon-summary:before, .addon-summary:after {display:table}
</style>

Wrongly becomes

<style>
    .addon-summary: before, .addon-summary: after {
        display: table
    }
</style>
@evocateur
Copy link
Contributor

Yoiks, that's bad. :(

@bthorben
Copy link
Contributor

bthorben commented Nov 9, 2013

Will fix this as soon as possible. Good that there are now some tests in the js and python version ;)
It would be very good if failing unittests could be added in the future

bthorben added a commit to bthorben/js-beautify that referenced this issue Nov 10, 2013
bthorben added a commit to bthorben/js-beautify that referenced this issue Nov 10, 2013
@varemenos
Copy link

Any news on this? I apologize for nagging you but it's a pretty serious bug.

@sethwklein
Copy link

This is fixed in 1.5.1 and should be closed.

echo 'a:hover{}' | css-beautify -f -
a:hover {}

@bitwiseman
Copy link
Member

Agreed.

@bitwiseman bitwiseman added this to the v1.5.1 milestone Sep 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants