-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
braces "expand-strict", return { } should be on same line #236
Comments
This is why you shouldn't use |
@mitermayer, I think you want @einars, Why do we even have the We know it will produce javascript that is functionally different from the input in cases like this one. Perhaps we should remove it. If not, we should at least add to the help output warning about this known issue. |
I've dug up the corresponding correspondence with author, I quote him,
I think it's time to let go of this strange and subtly destructive option. |
The only reson why i used expand-strict was because it allowed inline
Is there any other way to achieve that with the |
Thats only for anonymous empty functions |
That's even more awesome - the setting that will break We should fix that. |
But we should have a setting to allow
Instead of appearing
So what are other options ? |
We could make empty braces always collapse. |
@bitwiseman i think that would be a great idea, could we create an issue to address that ? |
While removing expand-strict, found that brace tests were uneven. Made all tests appear for all three settings, and adjusted for each. There are still some minor odd behaviors around empty braces, but they are non-breaking. Closes beautifier#236, beautifier#237
when running with settings expand-strict it should still allow
instead of
to avoid javascript ghost semi collon auto add
The text was updated successfully, but these errors were encountered: