Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update deploy action to use ghcr #702

Merged
merged 1 commit into from
Oct 18, 2024
Merged

update deploy action to use ghcr #702

merged 1 commit into from
Oct 18, 2024
+82 −5

Conversation

jsegal205
Copy link
Contributor

@jsegal205 jsegal205 commented Oct 18, 2024 •
edited
Loading

Updated the deploy script to utilize github container repo.

I stole this code from elixirschool/school_house#228

frank

@jsegal205 jsegal205 requested a review from a team as a code owner October 18, 2024 15:29
@jsegal205
Copy link
Contributor Author

@btkostner can you take a look at this and make sure that all the secrets are applied to this repo as well?

btkostner
btkostner approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@btkostner btkostner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't need any new secrets as the GITHUB_TOKEN built in secret should have enough permissions. All looks good.

@btkostner btkostner added this pull request to the merge queue Oct 18, 2024
Merged via the queue into beam-community:main with commit a2af7c4 Oct 18, 2024
5 checks passed
@jsegal205
Copy link
Contributor Author

@btkostner @doomspork https://github.com/beam-community/elixir-companies/actions/runs/11407727499/job/31744528235 looks like it failed on deploy for an authentication reason. Could you take a look at the settings for actions in this repo please and let me know what I can do to help?

re - https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry

@btkostner
Copy link
Member

@jsegal205 Updated and working now: https://github.com/beam-community/elixir-companies/actions/runs/11407727499/job/31745386485

@doomspork
Copy link
Member

Thank you @jsegal205 and @btkostner! 🫶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btkostner btkostner btkostner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsegal205 @btkostner @doomspork