Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

company slugs #588

Open
gemantzu opened this issue Feb 14, 2020 · 1 comment
Open

company slugs #588

gemantzu opened this issue Feb 14, 2020 · 1 comment
Labels
enhancement A new feature or enhancement to the existing functionality help wanted Get involved! We'd love to have your help.

Comments

@gemantzu
Copy link
Collaborator

It seems that some people are messing with the urls, trying to find their company. I see some errors in the form of /en/companies/CompanyName. Should we add a slug field for the company name or should we just try to find the company based on the url followed?
@doomspork
Copy link
Member

Yeah. We need to support slugs. We get hundreds of hits of people trying to use them.

@gemantzu gemantzu added enhancement A new feature or enhancement to the existing functionality help wanted Get involved! We'd love to have your help. labels Feb 21, 2020
@DouglasLutz DouglasLutz mentioned this issue Mar 4, 2020
Closed
@doomspork doomspork mentioned this issue Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A new feature or enhancement to the existing functionality help wanted Get involved! We'd love to have your help.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Change url companies param on :show route to name attribute DouglasLutz/elixir-companies
2 participants
@doomspork @gemantzu