Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

Ctrl-w closes browser instead of tab in Linux #380

Closed
morganrallen opened this issue Apr 4, 2017 · 12 comments
Closed

Ctrl-w closes browser instead of tab in Linux #380

morganrallen opened this issue Apr 4, 2017 · 12 comments
Labels

Comments

@morganrallen
Copy link

Operation System: Linux
Beaker Version: master

Expected behavior is to close tab

@pfrazee
Copy link
Member

pfrazee commented Apr 4, 2017

Thanks for reporting! We'll check into it.

@pfrazee pfrazee added the bug label Apr 4, 2017
@pfrazee pfrazee changed the title ctrl-w closes browser instead of tab Ctrl-w closes browser instead of tab in Linux Apr 19, 2017
@pmario
Copy link
Contributor

pmario commented May 2, 2017

IMO that's only true if the last tab is closed.

Try:

  • Open several tabs
  • type Ctrl-W

tested with latest v0.7 branch from 2.May.2017

@chartgerink
Copy link
Contributor

Echoing @pmario comment for Beaker 0.8 (54f8323) on Fedora. Isn't it default behavior across browsers to close the window with CTRL+W if it's the last tab (except Opera in my experience)?

@pfrazee
Copy link
Member

pfrazee commented Nov 5, 2017

Yes, @morganrallen did you have other tabs open? If not, then the browser is supposed to close if you closed the last tab

@theorangepotato
Copy link

theorangepotato commented Nov 8, 2017

I am running Linux (Debian Stretch) with the latest stable Beaker (0.7.7), and pressing CTRL+W will close the entire window regardless of the number of tabs. Typically, pressing CTRL+W will only close the active tab in most browsers.

@pfrazee
Copy link
Member

pfrazee commented Nov 8, 2017

Ok weird stuff. I'll double check my build on ubuntu, because it does what you'd expect for ctrl+w.

@jrc03c
Copy link

jrc03c commented Nov 8, 2017

I'm also having the same problem on Xubuntu 16.04 and Beaker 0.7.7!

@morganrallen
Copy link
Author

@pfrazee as others reported, I had multiple tabs open.

@pfrazee
Copy link
Member

pfrazee commented Nov 14, 2017

We had an extraneous window-menu item that was bound to Ctrl+W. Some kind of precedence rules caused it to trigger in Linux but not OSX. Fixed now.

Thanks everybody! Sorry for doubting you 😄

@taniki
Copy link

taniki commented Nov 21, 2017

Do I need to add something to config?

I have done a git pull, and npm rebuild but the 0.7.9 still close the whole window instead of current tab.

@pfrazee
Copy link
Member

pfrazee commented Nov 21, 2017

Try running npm run burnthemall then npm start. If that doesnt solve it, LMK what distro you're using.

@taniki
Copy link

taniki commented Nov 22, 2017

solved (:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants