Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OrderedDict and OrderedSet #23

Open
haberdashPI opened this issue Jul 14, 2023 · 1 comment
Open

Support OrderedDict and OrderedSet #23

haberdashPI opened this issue Jul 14, 2023 · 1 comment

Comments

@haberdashPI
Copy link
Member

These two defy the expectation of the hash functions for Set and Dict objects. We should probably use https://github.com/cjdoris/PackageExtensionCompat.jl to implement a hash_method for these types that respects the ordering of elements.
@haberdashPI
Copy link
Member Author

Alternative, wait until Julia 1.10 is LTS, and use the extension feature. Probably best to implement for StableHashTraits 2.0 in that case (thus 1.* can be compatible with ≥ 1.6 and 2.0 with 1.10 and onwards).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@haberdashPI