Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra data movement with multi-worker batching #9

Open
kleinschmidt opened this issue Aug 18, 2022 · 0 comments
Open

extra data movement with multi-worker batching #9

kleinschmidt opened this issue Aug 18, 2022 · 0 comments

Comments

@kleinschmidt
Copy link
Member

@ericphanson noted in beacon-biosignals/OldOndaBatches.jl#18 that there's some apparently extraneous data movement in multi-worker batching: #18 (comment)

so here the "batch manager" (the process with the Batcher) fetch the future from the worker, and puts it on channel which is a remote channel to somewhere else (the trainer, I guess?). I wonder if that's extra data movement we don't strictly need

I guess we kinda do need it, bc if we just passed the remote channel on to the workers, they wouldn't know what order to do stuff in, and passing it through the batch manager let's us straighten out the order before loading up the remote channel.

This may or may not turn out to be an issue. One way around it would be to remotecall the put! to have it execute on the batch worker.

@kleinschmidt kleinschmidt transferred this issue from another repository Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant