Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw better error messages for defensive implicit AbstractRecord convert failures #50

Open
jrevels opened this issue Aug 8, 2022 · 0 comments

Comments

@jrevels
Copy link
Member

jrevels commented Aug 8, 2022

we should suggest that the caller explicitly constructs relevant Rows instead of relying on implicit conversion

ref #27 (comment)

In other words, I think in the example in the OP the caller should explicitly push!(signals::Vector{<:Signal}, Signal(nt)); depending on the situation the error that gets raised otherwise is actually "a feature" and not just an inconvenience depending on the caller's actual intentions, so we should continue to force them to express those intentions explicitly

In that case I'd advocate for defining convert and having it raise an error message explaining that intent

@jrevels jrevels changed the title throw better error messages for defensive implicit Row convert failures throw better error messages for defensive implicit AbstractRecord convert failures Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant