fix enzymejs#1488 by returning null for missing keys

bdwain · Feb 23, 2018 · 654f7be · 654f7be
1 parent 973f5c0
commit 654f7be
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 2 deletions.
diff --git a/packages/enzyme-test-suite/test/ReactWrapper-spec.jsx b/packages/enzyme-test-suite/test/ReactWrapper-spec.jsx
@@ -3152,6 +3152,15 @@ describeWithDOM('mount', () => {
       expect(wrapper.at(0).key()).to.equal('foo');
       expect(wrapper.at(1).key()).to.equal('bar');
     });
+
+    it('should return null when no key is specified', () => {
+      const wrapper = mount((
+        <ul>
+          <li>foo</li>
+        </ul>
+      )).find('li');
+      expect(wrapper.key()).to.equal(null);
+    });
   });
 
   describe('.matchesElement(node)', () => {

diff --git a/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx b/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx
@@ -4013,6 +4013,15 @@ describe('shallow', () => {
       expect(wrapper.at(0).key()).to.equal('foo');
       expect(wrapper.at(1).key()).to.equal('bar');
     });
+
+    it('should return null when no key is specified', () => {
+      const wrapper = shallow((
+        <ul>
+          <li>foo</li>
+        </ul>
+      )).find('li');
+      expect(wrapper.key()).to.equal(null);
+    });
   });
 
   describe('.matchesElement(node)', () => {

diff --git a/packages/enzyme/src/ReactWrapper.js b/packages/enzyme/src/ReactWrapper.js
@@ -703,7 +703,7 @@ class ReactWrapper {
    * @returns {String}
    */
   key() {
-    return this.single('key', n => n.key);
+    return this.single('key', n => (n.key === undefined ? null : n.key));
   }
 
   /**

diff --git a/packages/enzyme/src/ShallowWrapper.js b/packages/enzyme/src/ShallowWrapper.js
@@ -845,7 +845,7 @@ class ShallowWrapper {
    * @returns {String}
    */
   key() {
-    return this.single('key', n => n.key);
+    return this.single('key', n => (n.key === undefined ? null : n.key));
   }
 
   /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -703,7 +703,7 @@ class ReactWrapper { @@
        * @returns {String}
        */
       key() {
-        return this.single('key', n => n.key);
+        return this.single('key', n => (n.key === undefined ? null : n.key));
       }
       /**
@@ Expand Down @@