From b1999c6a3feb078389652d4d36abfecc641b145c Mon Sep 17 00:00:00 2001 From: bd_ Date: Fri, 10 Nov 2023 16:19:44 +0900 Subject: [PATCH] fix: remove duplicate vestigial Apply on Play menu item Closes: #70 --- CHANGELOG.md | 1 + Editor/ApplyOnPlay.cs | 10 ---------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5058fe7..439f03e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed ### Removed +- Removed a vestigial "Avatar Toolkit -> Apply on Play" menu item, which didn't do anything when selected. (#70) ### Security diff --git a/Editor/ApplyOnPlay.cs b/Editor/ApplyOnPlay.cs index c797be3..c850800 100644 --- a/Editor/ApplyOnPlay.cs +++ b/Editor/ApplyOnPlay.cs @@ -38,8 +38,6 @@ namespace nadena.dev.ndmf [InitializeOnLoad] internal static class ApplyOnPlay { - private const string MENU_NAME = "Tools/Avatar Toolkit/Apply on Play"; - /** * We need to process avatars before lyuma's av3 emulator wakes up and processes avatars; it does this in Awake, * so we have to do our processing in Awake as well. This seems to work fine when first entering play mode, but @@ -55,7 +53,6 @@ static ApplyOnPlay() { EditorApplication.playModeStateChanged += OnPlayModeStateChanged; ApplyOnPlayGlobalActivator.OnDemandProcessAvatar = MaybeProcessAvatar; - //EditorApplication.delayCall += () => Menu.SetChecked(MENU_NAME, ModularAvatarSettings.applyOnPlay); } private static void MaybeProcessAvatar(ApplyOnPlayGlobalActivator.OnDemandSource source, @@ -69,13 +66,6 @@ private static void MaybeProcessAvatar(ApplyOnPlayGlobalActivator.OnDemandSource } } - [MenuItem(MENU_NAME)] - private static void ToggleApplyOnPlay() - { - //ModularAvatarSettings.applyOnPlay = !ModularAvatarSettings.applyOnPlay; - //Menu.SetChecked(MENU_NAME, ModularAvatarSettings.applyOnPlay); - } - private static void OnPlayModeStateChanged(PlayModeStateChange obj) { if (obj == PlayModeStateChange.EnteredPlayMode)