From 91a2738c077c0875e5eb0c187bf487b60c338d9a Mon Sep 17 00:00:00 2001
From: bd_ <bd_@nadena.dev>
Date: Sat, 19 Oct 2024 15:02:04 -0700
Subject: [PATCH] fix: double dispose of proxy handles

Closes: #456
---
 CHANGELOG.md                                    | 1 +
 Editor/PreviewSystem/Rendering/ProxyPipeline.cs | 8 ++++----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index f2365a9..0825b3b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 
 ### Fixed
+- [#459] "Proxy object was destroyed improperly! Resetting pipeline..." error appears frequently
 
 ### Changed
 
diff --git a/Editor/PreviewSystem/Rendering/ProxyPipeline.cs b/Editor/PreviewSystem/Rendering/ProxyPipeline.cs
index ddcbca3..6d2a76f 100644
--- a/Editor/PreviewSystem/Rendering/ProxyPipeline.cs
+++ b/Editor/PreviewSystem/Rendering/ProxyPipeline.cs
@@ -383,11 +383,11 @@ public void Dispose()
                                 node.Result.Dispose();
                             }
                         }
+                    }
 
-                        foreach (var proxy in _proxies.Values)
-                        {
-                            proxy.Dispose();
-                        }
+                    foreach (var proxy in _proxies.Values)
+                    {
+                        proxy.Dispose();
                     }
                 },
                 CancellationToken.None,