Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip url encoding for OAuth->uri() #268

Closed
bucs-fan813 opened this issue Jan 13, 2019 · 1 comment
Closed

Add option to skip url encoding for OAuth->uri() #268

bucs-fan813 opened this issue Jan 13, 2019 · 1 comment

Comments

@bucs-fan813
Copy link
Contributor

Some OAuth endpoints (like stackoverflow) do not like the parameters passed with URL encoding. since OAuth->uri() uses http_build_query(), all URIs generated will have invalid characters. This specifically affects access_token and key parameters.

@KOTRET
Copy link
Contributor

KOTRET commented Jan 14, 2019

Maybe use http_build_query's enc_type = PHP_QUERY_RFC3986 for that purpose (only escape spaces) and set this as instance var, because the request-method uses http_build_query too?
Sidenote: please clean up your commit.

@ikkez ikkez closed this as completed in 7597131 Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants