Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve catanatron-play load time #208

Open
pachewise opened this issue Sep 6, 2022 · 1 comment
Open

Improve catanatron-play load time #208

pachewise opened this issue Sep 6, 2022 · 1 comment

Comments

@pachewise
Copy link
Contributor

pachewise commented Sep 6, 2022 •
edited
Loading

Right now, even using the --help flag takes a long time. I am assuming it's because we are eagerly importing libraries (for example, numpy, tensorflow) which may not be needed until the actual code is being executed.

This may be a symptom of a broader need for import / loading hygiene.

time catanatron-play --help gave 20s on my MacBook Pro:

image

image
@bcollazo
Copy link
Owner

Agreed! Feel free to open a PR on this!

@bcollazo bcollazo mentioned this issue Jan 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcollazo @pachewise