👷 Deploy request for catanatron-staging pending review.

Visit the deploys page to approve it

Pull Request Test Coverage Report for Build 11647641862

Details

• 20 of 21 (95.24%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.003%) to 95.969%

Totals
Change from base Build 10864300657:	-0.003%
Covered Lines:	1381
Relevant Lines:	1439

💛 - Coveralls

Hey @zarns Thanks for taking a stab at this! Could you share performance numbers before and after this change? The motivation for this is to allow for faster games / more games per second. I wonder what's the improvement of this.

It might also be interesting to show how does games that involve bots that do a lot of copying (.copy) are affected by this change. For example games with the MCTS bot.

Thanks again!

Looks like these changes make the games slightly faster on average with AlphaBetaPlayer/MCTSPlayer/RandomPlayer

• catanatron-play -n 1000
  • before: 43.4 sec
  • after: 42.5 sec
• catanatron-play --players=AB,R,W --num=100
  • before: 309.36 sec
  • after: 285.75 sec
• catanatron-play --players=AB,M --num=10
  • before: 62.27 sec
  • after: 66.8 sec (slightly slower?)
• catanatron-play --players=AB,M,R --num=20
  • before: 224.7 sec
  • after: 206.9 sec (slightly faster on average)