From 7a88f85a641da5f5137d0d968a00b248c9c32f30 Mon Sep 17 00:00:00 2001
From: Travis Semple <travis8814@gmail.com>
Date: Fri, 10 Nov 2023 12:21:37 -0800
Subject: [PATCH 1/9] Initial commit for changing from GOVN -> PREMIUM

---
 .../account-info/AccountAccessType.vue        | 35 +++----------------
 .../account-info/AccountInfo.vue              | 11 ++++--
 .../ManageBusinessDialog.vue                  |  1 -
 auth-web/src/locales/en.json                  |  1 -
 auth-web/src/services/payment.services.ts     |  4 +++
 auth-web/src/stores/org.ts                    | 14 ++++++--
 .../views/auth/staff/ReviewAccountView.vue    | 10 +++---
 .../unit/components/AccountAccessType.spec.ts |  4 +--
 8 files changed, 36 insertions(+), 44 deletions(-)

diff --git a/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue b/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
index 29dfe95baf..3fe50b0daf 100644
--- a/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
+++ b/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
@@ -60,7 +60,6 @@
                 v-model="selectedAccessType"
                 class="mt-0"
                 req
-                :rules="[selectedAccessTypeRules]"
               >
                 <v-radio
                   :key="AccessType.REGULAR"
@@ -75,19 +74,6 @@
                   data-test="radio-govn"
                 />
               </v-radio-group>
-              <div
-                v-if="!isPad"
-                class="d-flex pb-3"
-              >
-                <v-icon
-                  size="30"
-                  color="error"
-                  class="mt-1 mr-4"
-                >
-                  mdi-alert-circle-outline
-                </v-icon>
-                <span class="error-text">{{ $t('accountAccessTypeUpdateWarning') }}</span>
-              </div>
 
               <v-card-actions class="px-0 pt-0">
                 <v-row>
@@ -130,7 +116,7 @@
 </template>
 
 <script lang="ts">
-import { AccessType, Account, PaymentTypes } from '@/util/constants'
+import { AccessType, Account } from '@/util/constants'
 import { Component, Emit, Prop, Vue, Watch } from 'vue-property-decorator'
 import { Organization } from '@/models/Organization'
 
@@ -150,16 +136,13 @@ export default class AccountAccessType extends Vue {
   public AccessType = AccessType
   public isLoading = false
 
-  public get isPad (): boolean {
-    return this.currentOrgPaymentType && this.currentOrgPaymentType === PaymentTypes.PAD
-  }
-
+  // Only allow PREMIUM -> GOVN and GOVN -> PREMIUM
   public get isChangeButtonEnabled (): boolean {
     // Check access type and orgtype must be premium
     const accessType: any = this.organization.accessType
     const isAllowedAccessType = this.organization.orgType === Account.PREMIUM &&
-      [AccessType.REGULAR, AccessType.EXTRA_PROVINCIAL, AccessType.REGULAR_BCEID].includes(accessType)
-    return isAllowedAccessType && this.canChangeAccessType // canChangeAccessType is the role based access pasased as property
+      [AccessType.REGULAR, AccessType.EXTRA_PROVINCIAL, AccessType.REGULAR_BCEID, AccessType.GOVN].includes(accessType)
+    return isAllowedAccessType && this.canChangeAccessType // canChangeAccessType is the role based access passed as a property
   }
 
   public get getAccessTypeText (): string {
@@ -178,16 +161,8 @@ export default class AccountAccessType extends Vue {
     this.selectedAccessType = this.organization.accessType === AccessType.GOVN ? AccessType.GOVN : AccessType.REGULAR
   }
 
-  // Custom rules for selectedAccessType v-model in form
-  public selectedAccessTypeRules (): any {
-    return this.selectedAccessType === AccessType.GOVN ? true : 'Please select Government agency'
-  }
-
-  // Currently, there is only one way change from Regular access type accounts to GovN. Not the other way around
   public updateDetails () {
-    if (this.isPad && this.$refs.accountAccessTypeForm.validate()) {
-      this.$emit('update:updateAndSaveAccessTypeDetails', this.selectedAccessType)
-    }
+    this.$emit('update:updateAndSaveAccessTypeDetails', this.selectedAccessType)
   }
 
   @Emit('update:viewOnlyMode')
diff --git a/auth-web/src/components/auth/account-settings/account-info/AccountInfo.vue b/auth-web/src/components/auth/account-settings/account-info/AccountInfo.vue
index 26e03e52c8..7e98d88bcc 100644
--- a/auth-web/src/components/auth/account-settings/account-info/AccountInfo.vue
+++ b/auth-web/src/components/auth/account-settings/account-info/AccountInfo.vue
@@ -283,6 +283,7 @@
 
 <script lang="ts">
 import {
+  AccessType,
   AccountStatus,
   Pages,
   Permission,
@@ -341,10 +342,12 @@ export default class AccountInfo extends Mixins(
 
   @Action(useOrgStore) syncAddress!: () => Address
   @Action(useOrgStore) getOrgPayments!: () => any
-  @Action(useOrgStore) updateOrganizationAccessType!: (accessType: string) => Promise<Organization>
+  @Action(useOrgStore) updateOrganizationAccessType!: (accessType: string, orgId: number, syncOrg: boolean) =>
+    Promise<Organization>
 
   @Action(useOrgStore) syncOrganization!: (currentAccount: number) => Promise<Organization>
   @Action(useOrgStore) suspendOrganization!: (selectedSuspensionReasonCode: string) => Promise<Organization>
+  @Action(useOrgStore) removeOrgAccountFees!: (orgId: number) => Promise<void>
 
   private dialogTitle: string = ''
   private dialogText: string = ''
@@ -417,7 +420,11 @@ export default class AccountInfo extends Mixins(
 
   // update account access type from child component
   public async updateAndSaveAccessTypeDetails (accessType: string) {
-    await this.updateOrganizationAccessType(accessType)
+    await this.updateOrganizationAccessType(accessType, this.currentOrganization.id, true)
+    // Only remove the account fees if going from GOVN -> PREMIUM (REGULAR)
+    if (accessType === AccessType.REGULAR) {
+      await this.removeOrgAccountFees(this.currentOrganization.id)
+    }
     this.viewOnlyMode({ component: 'accessType', mode: true })
   }
 
diff --git a/auth-web/src/components/auth/manage-business/manage-business-dialog/ManageBusinessDialog.vue b/auth-web/src/components/auth/manage-business/manage-business-dialog/ManageBusinessDialog.vue
index 616198df16..e40ffe9e27 100644
--- a/auth-web/src/components/auth/manage-business/manage-business-dialog/ManageBusinessDialog.vue
+++ b/auth-web/src/components/auth/manage-business/manage-business-dialog/ManageBusinessDialog.vue
@@ -564,7 +564,6 @@ export default defineComponent({
       }
     })
 
-
     // Methods
     const closeAuthorizationRequestSentDialog = () => {
       authorizationRequestSentDialog.value?.close()
diff --git a/auth-web/src/locales/en.json b/auth-web/src/locales/en.json
index d167d1e039..6f443a753a 100644
--- a/auth-web/src/locales/en.json
+++ b/auth-web/src/locales/en.json
@@ -216,7 +216,6 @@
   "acceptInviteLandingMessageBCEID": "To accept the invitation to this account, log in to Business Registry with a registered BCeID account, and verify your identity by a notarized affidavit.",
   "pendingAffidavitAdminReviewTitle":"Your submission to join {team} has been requested ",
   "pendingAffidvitAdminReviewMessage":"Once your information has been reviewed and approved, you will receive an email allowing you to join the account. Please allow {days} business days for this process",
-  "accountAccessTypeUpdateWarning": "This account currently can't change access type. Contact account admin to update the payment method to PAD in order to change the access type.",
   "govnAccountDescription": "Service BC Staff will manually review your account information.",
   "govnConfirmText": "BC Registry Staff will manually review the account to verify the account user. <b>Account will be rejected if account admin does not verify as a government other than BC provincial. </b>This is a option for townships, cities, districts, municipalities, and federal government.",
   "searchAccountNoResult": "<h4>No Results</h4><p>None of the accounts matched this search. Try another search.</p>",
diff --git a/auth-web/src/services/payment.services.ts b/auth-web/src/services/payment.services.ts
index 642600c2fa..106ba30597 100644
--- a/auth-web/src/services/payment.services.ts
+++ b/auth-web/src/services/payment.services.ts
@@ -188,4 +188,8 @@ export default class PaymentService {
     const { product } = accountFeePayload
     return axios.put(`${ConfigHelper.getPayAPIURL()}/accounts/${accountId}/fees/${product}`, accountFeePayload)
   }
+
+  static removeAccountFees (accountId: string | number): AxiosPromise<any> {
+    return axios.delete(`${ConfigHelper.getPayAPIURL()}/accounts/${accountId}/fees`)
+  }
 }
diff --git a/auth-web/src/stores/org.ts b/auth-web/src/stores/org.ts
index 9d96084b68..1215c0e0d8 100644
--- a/auth-web/src/stores/org.ts
+++ b/auth-web/src/stores/org.ts
@@ -997,7 +997,7 @@ export const useOrgStore = defineStore('org', () => {
     return response?.data || {}
   }
 
-  async function updateOrganizationAccessType ({ accessType, orgId = null, syncOrg = true }): Promise<boolean> {
+  async function updateOrganizationAccessType (accessType: string, orgId: number = null, syncOrg = true): Promise<boolean> {
     if (!orgId) orgId = state.currentOrganization?.id as number
     if (orgId && accessType) {
       try {
@@ -1018,6 +1018,15 @@ export const useOrgStore = defineStore('org', () => {
     }
   }
 
+  async function removeOrgAccountFees (orgId: number) {
+    try {
+      await PaymentService.removeAccountFees(orgId)
+    } catch (error) {
+      // eslint-disable-next-line no-console
+      console.error('remove org account fees operation failed! - ', error)
+    }
+  }
+
   return {
     ...toRefs(state),
     isPremiumAccount,
@@ -1113,6 +1122,7 @@ export const useOrgStore = defineStore('org', () => {
     revokeOrgApiKeys,
     updateOrganizationAccessType,
     $reset,
-    isStaffOrSbcStaff
+    isStaffOrSbcStaff,
+    removeOrgAccountFees
   }
 })
diff --git a/auth-web/src/views/auth/staff/ReviewAccountView.vue b/auth-web/src/views/auth/staff/ReviewAccountView.vue
index 4a21291327..f7f39eefaf 100644
--- a/auth-web/src/views/auth/staff/ReviewAccountView.vue
+++ b/auth-web/src/views/auth/staff/ReviewAccountView.vue
@@ -186,7 +186,7 @@ export default defineComponent({
     const taskRelationshipType: Ref<string> = ref('')
     const productFeeFormValid: Ref<boolean> = ref(false)
     const viewOnly = DisplayModeValues.VIEW_ONLY
-    const accountInfoAccessType = ref(null)
+    const accountInfoAccessType = ref<string>(null)
     const accountInfoValid: Ref<boolean> = ref(true)
     const showAccountInfoValidations: Ref<boolean> = ref(false)
 
@@ -598,11 +598,9 @@ export default defineComponent({
 
       try {
         if (accountInfoAccessType.value && accountInfoAccessType.value !== accountUnderReview.value.accessType) {
-          const success = await orgStore.updateOrganizationAccessType({
-            accessType: accountInfoAccessType.value as string,
-            orgId: accountUnderReview.value.id,
-            syncOrg: false
-          })
+          const success = await orgStore.updateOrganizationAccessType(
+            accountInfoAccessType.value, accountUnderReview.value.id, false
+          )
           if (!success) throw new Error('Error updating account access type prevented review completion.')
         }
         if (isApprove) {
diff --git a/auth-web/tests/unit/components/AccountAccessType.spec.ts b/auth-web/tests/unit/components/AccountAccessType.spec.ts
index 6f02b91e90..673b249ec0 100644
--- a/auth-web/tests/unit/components/AccountAccessType.spec.ts
+++ b/auth-web/tests/unit/components/AccountAccessType.spec.ts
@@ -87,7 +87,7 @@ describe('AccountAccessType.vue', () => {
     expect(wrapper.vm.currentOrgPaymentTypePad).toBeFalsy()
   })
 
-  it('validate view mode with govn org', () => {
+  it('validate view mode with govn org, should be able to change to PREMIUM', () => {
     const $t = () => ''
     const govnOrg = organization
     govnOrg.accessType = AccessType.GOVN
@@ -106,7 +106,7 @@ describe('AccountAccessType.vue', () => {
     expect(wrapper.find('[data-test="title"]').text()).toBe('Access Type')
     expect(wrapper.find('[data-test="txt-selected-access-type"]').text())
       .toBe('Government agency (other than BC provincial)')
-    expect(wrapper.find('[data-test="btn-edit"]').exists()).toBeFalsy()
+    expect(wrapper.find('[data-test="btn-edit"]').exists()).toBeTruthy()
   })
 
   it('validate view mode with govm org', () => {

From f9637c09f3690a1c9156a53cf72656398659590e Mon Sep 17 00:00:00 2001
From: Travis Semple <travis8814@gmail.com>
Date: Wed, 15 Nov 2023 13:09:58 -0800
Subject: [PATCH 2/9] Implement dialog for AccountAccessType

---
 .../account-info/AccountAccessType.vue        | 76 +++++++++++++++++--
 1 file changed, 68 insertions(+), 8 deletions(-)

diff --git a/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue b/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
index 3fe50b0daf..366b9e2ccd 100644
--- a/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
+++ b/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
@@ -112,6 +112,48 @@
         </div>
       </v-card>
     </v-form>
+    <!-- Confirm Access Type To Regular Dialog -->
+    <ModalDialog
+      ref="changeAccessTypeToRegularDialog"
+      title="Change Access Type To Regular?"
+      text="Regular access will not have the option to modify product fees."
+      dialog-class="notify-dialog"
+      max-width="680"
+      :isPersistent="true"
+      data-test="modal-suspension-complete"
+    >
+      <template #icon>
+        <v-icon
+          large
+          color="error"
+        >
+          mdi-alert-circle-outline
+        </v-icon>
+      </template>
+      <template #actions>
+        <v-btn
+          large
+          depressed
+          class="font-weight-bold btn-dialog"
+          data-test="btn-confirm-change-access-type-dialog"
+          color="primary"
+          @click="updateDetails(true)"
+        >
+          Confirm
+        </v-btn>
+        <v-btn
+          outlined
+          large
+          depressed
+          class="btn-dialog"
+          color="primary"
+          data-test="btn-cancel-change-access-type-dialog"
+          @click="closeDialog"
+        >
+          Cancel
+        </v-btn>
+      </template>
+    </ModalDialog>
   </div>
 </template>
 
@@ -119,8 +161,12 @@
 import { AccessType, Account } from '@/util/constants'
 import { Component, Emit, Prop, Vue, Watch } from 'vue-property-decorator'
 import { Organization } from '@/models/Organization'
+import ModalDialog from '@/components/auth/common/ModalDialog.vue'
 
 @Component({
+  components: {
+    ModalDialog
+  }
 })
 export default class AccountAccessType extends Vue {
   @Prop({ default: undefined }) organization: Organization
@@ -130,14 +176,15 @@ export default class AccountAccessType extends Vue {
 
   $refs: {
     accountAccessTypeForm: HTMLFormElement,
-    selectedAccessType: HTMLFormElement
+    changeAccessTypeToRegularDialog: InstanceType<typeof ModalDialog>
+    selectedAccessType: HTMLFormElement,
   }
-  private selectedAccessType: string = undefined
-  public AccessType = AccessType
-  public isLoading = false
+  selectedAccessType: string = undefined
+  AccessType = AccessType
+  isLoading = false
 
   // Only allow PREMIUM -> GOVN and GOVN -> PREMIUM
-  public get isChangeButtonEnabled (): boolean {
+  get isChangeButtonEnabled (): boolean {
     // Check access type and orgtype must be premium
     const accessType: any = this.organization.accessType
     const isAllowedAccessType = this.organization.orgType === Account.PREMIUM &&
@@ -145,7 +192,7 @@ export default class AccountAccessType extends Vue {
     return isAllowedAccessType && this.canChangeAccessType // canChangeAccessType is the role based access passed as a property
   }
 
-  public get getAccessTypeText (): string {
+  get getAccessTypeText (): string {
     let accessTypeText = 'Regular Access'
     if (this.organization.accessType === AccessType.GOVN) {
       accessTypeText = 'Government agency (other than BC provincial)'
@@ -161,8 +208,17 @@ export default class AccountAccessType extends Vue {
     this.selectedAccessType = this.organization.accessType === AccessType.GOVN ? AccessType.GOVN : AccessType.REGULAR
   }
 
-  public updateDetails () {
-    this.$emit('update:updateAndSaveAccessTypeDetails', this.selectedAccessType)
+  updateDetails (confirmed: boolean) {
+    if (this.selectedAccessType === AccessType.REGULAR && !confirmed) {
+      this.$refs.changeAccessTypeToRegularDialog.open()
+    } else {
+      this.$emit('update:updateAndSaveAccessTypeDetails', this.selectedAccessType)
+      this.$refs.changeAccessTypeToRegularDialog.close()
+    }
+  }
+
+  closeDialog () {
+    this.$refs.changeAccessTypeToRegularDialog.close()
   }
 
   @Emit('update:viewOnlyMode')
@@ -186,4 +242,8 @@ export default class AccountAccessType extends Vue {
   color: var(--v-error-base) !important;
 }
 
+.btn-dialog {
+  height: 2.75em;
+  width: 6.25em;
+}
 </style>

From 5c67d3caeb458140ceb95afa70964d2ebae035c7 Mon Sep 17 00:00:00 2001
From: Travis Semple <travis8814@gmail.com>
Date: Wed, 15 Nov 2023 13:28:59 -0800
Subject: [PATCH 3/9] Convert to composition api

---
 .../account-info/AccountAccessType.vue        | 141 ++++++++++--------
 1 file changed, 79 insertions(+), 62 deletions(-)

diff --git a/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue b/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
index 366b9e2ccd..c5a84e9225 100644
--- a/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
+++ b/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
@@ -1,6 +1,6 @@
 <template>
   <div>
-    <v-form ref="accountAccessTypeForm">
+    <v-form>
       <v-card elevation="0">
         <div class="account-label">
           <div
@@ -88,7 +88,7 @@
                       color="primary"
                       :loading="false"
                       aria-label="Save Account Access Type"
-                      @click="updateDetails()"
+                      @click="updateDetails(false)"
                     >
                       <span class="save-btn__label">Save</span>
                     </v-btn>
@@ -159,77 +159,94 @@
 
 <script lang="ts">
 import { AccessType, Account } from '@/util/constants'
-import { Component, Emit, Prop, Vue, Watch } from 'vue-property-decorator'
-import { Organization } from '@/models/Organization'
 import ModalDialog from '@/components/auth/common/ModalDialog.vue'
+import { reactive, computed, defineComponent, watch, toRefs } from '@vue/composition-api'
 
-@Component({
+export default defineComponent({
+  name: 'AccountAccessType',
   components: {
     ModalDialog
-  }
-})
-export default class AccountAccessType extends Vue {
-  @Prop({ default: undefined }) organization: Organization
-  @Prop({ default: true }) viewOnlyMode: boolean
-  @Prop({ default: false }) canChangeAccessType: boolean
-  @Prop({ default: undefined }) currentOrgPaymentType: string
+  },
+  props: {
+    organization: {
+      type: Object,
+      default: undefined,
+    },
+    viewOnlyMode: {
+      type: Boolean,
+      default: true,
+    },
+    canChangeAccessType: {
+      type: Boolean,
+      default: false,
+    },
+    currentOrgPaymentType: {
+      type: String,
+      default: undefined,
+    },
+  },
+  emits: ['update:updateAndSaveAccessTypeDetails', 'update:viewOnlyMode'],
+  setup(props , { emit }) {
+      // const AccessType = AccessType
+      const state = reactive({
+        changeAccessTypeToRegularDialog: null,
+        selectedAccessType: undefined,
+        isLoading: false,
+        // Only allow PREMIUM -> GOVN and GOVN -> PREMIUM
+        isChangeButtonEnabled: computed<boolean>(() => {
+          // Check access type and orgtype must be premium
+          const accessType: any = props.organization.accessType
+          const isAllowedAccessType = props.organization.orgType === Account.PREMIUM &&
+            [AccessType.REGULAR, AccessType.EXTRA_PROVINCIAL, AccessType.REGULAR_BCEID, AccessType.GOVN].includes(accessType)
+          return isAllowedAccessType && props.canChangeAccessType // canChangeAccessType is the role based access passed as a property
+        }),
+        getAccessTypeText: computed<string>(() => {
+          let accessTypeText = 'Regular Access'
+          if (props.organization.accessType === AccessType.GOVN) {
+            accessTypeText = 'Government agency (other than BC provincial)'
+          } else if (props.organization.accessType === AccessType.GOVM) {
+            accessTypeText = 'BC Government Ministry'
+          }
+          return accessTypeText
+        })
+      })
 
-  $refs: {
-    accountAccessTypeForm: HTMLFormElement,
-    changeAccessTypeToRegularDialog: InstanceType<typeof ModalDialog>
-    selectedAccessType: HTMLFormElement,
-  }
-  selectedAccessType: string = undefined
-  AccessType = AccessType
-  isLoading = false
+      const updateDetails = (confirmed: boolean) => {
+        if (state.selectedAccessType === AccessType.REGULAR && !confirmed) {
+          state.changeAccessTypeToRegularDialog.open()
+        } else {
+          emit('update:updateAndSaveAccessTypeDetails', state.selectedAccessType)
+          state.changeAccessTypeToRegularDialog.close()
+        }
+      }
 
-  // Only allow PREMIUM -> GOVN and GOVN -> PREMIUM
-  get isChangeButtonEnabled (): boolean {
-    // Check access type and orgtype must be premium
-    const accessType: any = this.organization.accessType
-    const isAllowedAccessType = this.organization.orgType === Account.PREMIUM &&
-      [AccessType.REGULAR, AccessType.EXTRA_PROVINCIAL, AccessType.REGULAR_BCEID, AccessType.GOVN].includes(accessType)
-    return isAllowedAccessType && this.canChangeAccessType // canChangeAccessType is the role based access passed as a property
-  }
+      const closeDialog = () => {
+        state.changeAccessTypeToRegularDialog.close()
+      }
 
-  get getAccessTypeText (): string {
-    let accessTypeText = 'Regular Access'
-    if (this.organization.accessType === AccessType.GOVN) {
-      accessTypeText = 'Government agency (other than BC provincial)'
-    } else if (this.organization.accessType === AccessType.GOVM) {
-      accessTypeText = 'BC Government Ministry'
-    }
-    return accessTypeText
-  }
+      const cancelEdit = () => {
+        state.selectedAccessType = props.organization.accessType === AccessType.GOVN ? AccessType.GOVN : AccessType.REGULAR
+        emit('update:viewOnlyMode', {
+          component: 'accessType',
+          mode: true
+        })
+      }
 
-  // Watch property access type and update model
-  @Watch('organization', { deep: true, immediate: true })
-  onOrganizationChange () {
-    this.selectedAccessType = this.organization.accessType === AccessType.GOVN ? AccessType.GOVN : AccessType.REGULAR
-  }
+      // Watch property access type and update model
+      watch(() => props.organization, (newVal) => {
+        state.selectedAccessType = newVal.accessType === AccessType.GOVN ? AccessType.GOVN : AccessType.REGULAR
+      }, { deep: true, immediate: true })
 
-  updateDetails (confirmed: boolean) {
-    if (this.selectedAccessType === AccessType.REGULAR && !confirmed) {
-      this.$refs.changeAccessTypeToRegularDialog.open()
-    } else {
-      this.$emit('update:updateAndSaveAccessTypeDetails', this.selectedAccessType)
-      this.$refs.changeAccessTypeToRegularDialog.close()
-    }
-  }
-
-  closeDialog () {
-    this.$refs.changeAccessTypeToRegularDialog.close()
-  }
 
-  @Emit('update:viewOnlyMode')
-  cancelEdit () {
-    this.selectedAccessType = this.organization.accessType === AccessType.GOVN ? AccessType.GOVN : AccessType.REGULAR
-    return {
-      component: 'accessType',
-      mode: true
-    }
+      return {
+        AccessType,
+        ...toRefs(state),
+        updateDetails,
+        closeDialog,
+        cancelEdit
+      }
   }
-}
+})
 </script>
 
 <style lang="scss" scoped>

From 5ac4297ffffcc3b50825f5e2b3d60c427c1ff15d Mon Sep 17 00:00:00 2001
From: Travis Semple <travis8814@gmail.com>
Date: Wed, 15 Nov 2023 13:30:52 -0800
Subject: [PATCH 4/9] Use closedialog instead.

---
 .../auth/account-settings/account-info/AccountAccessType.vue    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue b/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
index c5a84e9225..caf952c429 100644
--- a/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
+++ b/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
@@ -216,7 +216,7 @@ export default defineComponent({
           state.changeAccessTypeToRegularDialog.open()
         } else {
           emit('update:updateAndSaveAccessTypeDetails', state.selectedAccessType)
-          state.changeAccessTypeToRegularDialog.close()
+          closeDialog()
         }
       }
 

From d9680b29df4ed0216d8ce1b8f5760c149e9b2353 Mon Sep 17 00:00:00 2001
From: Travis Semple <travis8814@gmail.com>
Date: Wed, 15 Nov 2023 13:33:11 -0800
Subject: [PATCH 5/9] Redundant comment

---
 .../auth/account-settings/account-info/AccountAccessType.vue     | 1 -
 1 file changed, 1 deletion(-)

diff --git a/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue b/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
index caf952c429..b668785a4f 100644
--- a/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
+++ b/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
@@ -232,7 +232,6 @@ export default defineComponent({
         })
       }
 
-      // Watch property access type and update model
       watch(() => props.organization, (newVal) => {
         state.selectedAccessType = newVal.accessType === AccessType.GOVN ? AccessType.GOVN : AccessType.REGULAR
       }, { deep: true, immediate: true })

From ca81b26aeb052bae4f4329e77bd278f7578ec0b9 Mon Sep 17 00:00:00 2001
From: Travis Semple <travis8814@gmail.com>
Date: Wed, 15 Nov 2023 13:39:19 -0800
Subject: [PATCH 6/9] Fix width and data-test tags.

---
 .../auth/account-settings/account-info/AccountAccessType.vue  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue b/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
index b668785a4f..365db94ac9 100644
--- a/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
+++ b/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
@@ -118,9 +118,9 @@
       title="Change Access Type To Regular?"
       text="Regular access will not have the option to modify product fees."
       dialog-class="notify-dialog"
-      max-width="680"
+      max-width="720"
       :isPersistent="true"
-      data-test="modal-suspension-complete"
+      data-test="modal-change-access-type"
     >
       <template #icon>
         <v-icon

From 3f3528d7ac89d10e0b9ebd84ee7857ad3ec7a8f7 Mon Sep 17 00:00:00 2001
From: Travis Semple <travis8814@gmail.com>
Date: Wed, 15 Nov 2023 13:39:49 -0800
Subject: [PATCH 7/9] Increase package version

---
 auth-web/package-lock.json | 4 ++--
 auth-web/package.json      | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/auth-web/package-lock.json b/auth-web/package-lock.json
index e258692ff1..9e64d4c024 100644
--- a/auth-web/package-lock.json
+++ b/auth-web/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "auth-web",
-  "version": "2.4.43",
+  "version": "2.4.44",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "auth-web",
-      "version": "2.4.43",
+      "version": "2.4.44",
       "dependencies": {
         "@bcrs-shared-components/base-address": "2.0.3",
         "@bcrs-shared-components/bread-crumb": "1.0.8",
diff --git a/auth-web/package.json b/auth-web/package.json
index 129da129d3..da8391b684 100644
--- a/auth-web/package.json
+++ b/auth-web/package.json
@@ -1,6 +1,6 @@
 {
   "name": "auth-web",
-  "version": "2.4.43",
+  "version": "2.4.44",
   "appName": "Auth Web",
   "sbcName": "SBC Common Components",
   "private": true,

From 4bd53383c176c92804fdfc58f43f858cb1f41692 Mon Sep 17 00:00:00 2001
From: Travis Semple <travis8814@gmail.com>
Date: Wed, 15 Nov 2023 13:41:07 -0800
Subject: [PATCH 8/9] fix signature

---
 .../auth/account-settings/account-info/AccountInfo.vue          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/auth-web/src/components/auth/account-settings/account-info/AccountInfo.vue b/auth-web/src/components/auth/account-settings/account-info/AccountInfo.vue
index 7e98d88bcc..d46566245e 100644
--- a/auth-web/src/components/auth/account-settings/account-info/AccountInfo.vue
+++ b/auth-web/src/components/auth/account-settings/account-info/AccountInfo.vue
@@ -343,7 +343,7 @@ export default class AccountInfo extends Mixins(
   @Action(useOrgStore) syncAddress!: () => Address
   @Action(useOrgStore) getOrgPayments!: () => any
   @Action(useOrgStore) updateOrganizationAccessType!: (accessType: string, orgId: number, syncOrg: boolean) =>
-    Promise<Organization>
+    Promise<boolean>
 
   @Action(useOrgStore) syncOrganization!: (currentAccount: number) => Promise<Organization>
   @Action(useOrgStore) suspendOrganization!: (selectedSuspensionReasonCode: string) => Promise<Organization>

From f12af83160b6d98f28e547f63745c09c94e5d889 Mon Sep 17 00:00:00 2001
From: Travis Semple <travis8814@gmail.com>
Date: Wed, 15 Nov 2023 13:45:32 -0800
Subject: [PATCH 9/9] lint fixes

---
 .../account-info/AccountAccessType.vue        | 111 +++++++++---------
 1 file changed, 55 insertions(+), 56 deletions(-)

diff --git a/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue b/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
index 365db94ac9..55f3b00ece 100644
--- a/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
+++ b/auth-web/src/components/auth/account-settings/account-info/AccountAccessType.vue
@@ -159,8 +159,8 @@
 
 <script lang="ts">
 import { AccessType, Account } from '@/util/constants'
+import { computed, defineComponent, reactive, toRefs, watch } from '@vue/composition-api'
 import ModalDialog from '@/components/auth/common/ModalDialog.vue'
-import { reactive, computed, defineComponent, watch, toRefs } from '@vue/composition-api'
 
 export default defineComponent({
   name: 'AccountAccessType',
@@ -170,80 +170,79 @@ export default defineComponent({
   props: {
     organization: {
       type: Object,
-      default: undefined,
+      default: undefined
     },
     viewOnlyMode: {
       type: Boolean,
-      default: true,
+      default: true
     },
     canChangeAccessType: {
       type: Boolean,
-      default: false,
+      default: false
     },
     currentOrgPaymentType: {
       type: String,
-      default: undefined,
-    },
+      default: undefined
+    }
   },
   emits: ['update:updateAndSaveAccessTypeDetails', 'update:viewOnlyMode'],
-  setup(props , { emit }) {
-      // const AccessType = AccessType
-      const state = reactive({
-        changeAccessTypeToRegularDialog: null,
-        selectedAccessType: undefined,
-        isLoading: false,
-        // Only allow PREMIUM -> GOVN and GOVN -> PREMIUM
-        isChangeButtonEnabled: computed<boolean>(() => {
-          // Check access type and orgtype must be premium
-          const accessType: any = props.organization.accessType
-          const isAllowedAccessType = props.organization.orgType === Account.PREMIUM &&
+  setup (props, { emit }) {
+    // const AccessType = AccessType
+    const state = reactive({
+      changeAccessTypeToRegularDialog: null,
+      selectedAccessType: undefined,
+      isLoading: false,
+      // Only allow PREMIUM -> GOVN and GOVN -> PREMIUM
+      isChangeButtonEnabled: computed<boolean>(() => {
+        // Check access type and orgtype must be premium
+        const accessType: any = props.organization.accessType
+        const isAllowedAccessType = props.organization.orgType === Account.PREMIUM &&
             [AccessType.REGULAR, AccessType.EXTRA_PROVINCIAL, AccessType.REGULAR_BCEID, AccessType.GOVN].includes(accessType)
-          return isAllowedAccessType && props.canChangeAccessType // canChangeAccessType is the role based access passed as a property
-        }),
-        getAccessTypeText: computed<string>(() => {
-          let accessTypeText = 'Regular Access'
-          if (props.organization.accessType === AccessType.GOVN) {
-            accessTypeText = 'Government agency (other than BC provincial)'
-          } else if (props.organization.accessType === AccessType.GOVM) {
-            accessTypeText = 'BC Government Ministry'
-          }
-          return accessTypeText
-        })
-      })
-
-      const updateDetails = (confirmed: boolean) => {
-        if (state.selectedAccessType === AccessType.REGULAR && !confirmed) {
-          state.changeAccessTypeToRegularDialog.open()
-        } else {
-          emit('update:updateAndSaveAccessTypeDetails', state.selectedAccessType)
-          closeDialog()
+        return isAllowedAccessType && props.canChangeAccessType // canChangeAccessType is the role based access passed as a property
+      }),
+      getAccessTypeText: computed<string>(() => {
+        let accessTypeText = 'Regular Access'
+        if (props.organization.accessType === AccessType.GOVN) {
+          accessTypeText = 'Government agency (other than BC provincial)'
+        } else if (props.organization.accessType === AccessType.GOVM) {
+          accessTypeText = 'BC Government Ministry'
         }
-      }
+        return accessTypeText
+      })
+    })
 
-      const closeDialog = () => {
-        state.changeAccessTypeToRegularDialog.close()
-      }
+    const closeDialog = () => {
+      state.changeAccessTypeToRegularDialog.close()
+    }
 
-      const cancelEdit = () => {
-        state.selectedAccessType = props.organization.accessType === AccessType.GOVN ? AccessType.GOVN : AccessType.REGULAR
-        emit('update:viewOnlyMode', {
-          component: 'accessType',
-          mode: true
-        })
+    const updateDetails = (confirmed: boolean) => {
+      if (state.selectedAccessType === AccessType.REGULAR && !confirmed) {
+        state.changeAccessTypeToRegularDialog.open()
+      } else {
+        emit('update:updateAndSaveAccessTypeDetails', state.selectedAccessType)
+        closeDialog()
       }
+    }
 
-      watch(() => props.organization, (newVal) => {
-        state.selectedAccessType = newVal.accessType === AccessType.GOVN ? AccessType.GOVN : AccessType.REGULAR
-      }, { deep: true, immediate: true })
+    const cancelEdit = () => {
+      state.selectedAccessType = props.organization.accessType === AccessType.GOVN ? AccessType.GOVN : AccessType.REGULAR
+      emit('update:viewOnlyMode', {
+        component: 'accessType',
+        mode: true
+      })
+    }
 
+    watch(() => props.organization, (newVal) => {
+      state.selectedAccessType = newVal.accessType === AccessType.GOVN ? AccessType.GOVN : AccessType.REGULAR
+    }, { deep: true, immediate: true })
 
-      return {
-        AccessType,
-        ...toRefs(state),
-        updateDetails,
-        closeDialog,
-        cancelEdit
-      }
+    return {
+      AccessType,
+      ...toRefs(state),
+      closeDialog,
+      updateDetails,
+      cancelEdit
+    }
   }
 })
 </script>