Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #1542 User details link and breadcrumb change. #1589

Merged
merged 8 commits into from
Sep 12, 2024
Merged

feat: #1542 User details link and breadcrumb change. #1589

merged 8 commits into from
Sep 12, 2024

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Sep 12, 2024 •
edited
Loading

ref: #1542

  • Add icon and navigation to the new user details page.
  • Adjust breadcrumb.
  • Left out SideNav as discussed.

@craigyu craigyu self-requested a review September 12, 2024 19:10
@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review September 12, 2024 19:19
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'nr-forests-access-management_admin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

craigyu
craigyu approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@craigyu craigyu merged commit fa6b3ad into main Sep 12, 2024
12 checks passed
@craigyu craigyu deleted the feat/1542-user-details branch September 12, 2024 22:05
@github-actions github-actions bot mentioned this pull request Sep 5, 2024
Merged
@craigyu craigyu linked an issue Sep 12, 2024 that may be closed by this pull request
Add /user_details path to router and remove sub-menu items and adjust breadcrumbs #1542
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigyu craigyu craigyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add /user_details path to router and remove sub-menu items and adjust breadcrumbs
2 participants
@ianliuwk1019 @craigyu