Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth API - update firm affiliation logic to work in sandbox #25138

Closed
argush3 opened this issue Jan 4, 2025 · 2 comments
Closed

Auth API - update firm affiliation logic to work in sandbox #25138

argush3 opened this issue Jan 4, 2025 · 2 comments
Assignees
Labels
Entities - Lorrie A label to filter on the tickets for the Entities based team that David is PO for. sbc-connect

Comments

@argush3
Copy link
Collaborator

argush3 commented Jan 4, 2025

When a firm(corp_type_code = SP or GP) is created in the sandbox currently, the affiliation logic fails in prod auth api. It seems like other business types are fine from initial testing.

The issue appears to be that the auth api in prod fails for firm affiliations when it does the pass code validation in _validate_firms_party. Auth api is calling the prod legal api parties endpoint which fails because the business being affiliated only exists in sandbox.

To fix the issue, the firm passcode validation logic(_validate_firms_party) will need to be updated call the sandbox legal api parties endpoint when the POST affiliations call is called with the sandbox header(Environment-override: sandbox). A new config will need to be added for the sandbox legal api url.

image.png

image 2.png

@seeker25
Copy link
Collaborator

seeker25 commented Jan 7, 2025

Already deployed to prod

@seeker25
Copy link
Collaborator

seeker25 commented Jan 8, 2025

Reopen if needed

@seeker25 seeker25 closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entities - Lorrie A label to filter on the tickets for the Entities based team that David is PO for. sbc-connect
Projects
None yet
Development

No branches or pull requests

3 participants