Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - BC benefit company > Incorporation application draft: Missing titles etc #24661

Closed
3 tasks
saragunnarsson opened this issue Nov 28, 2024 · 6 comments
Closed
3 tasks
Assignees
Labels
BTR Business Transparency Register bug Something isn't working Priority1

Comments

@saragunnarsson
Copy link
Collaborator

saragunnarsson commented Nov 28, 2024

As a non staff user, when a BC benefit company has an Incorporation application in draft the pages shows up a little bit differently:

  • Missing title
  • slightly wrong subtitles
  • Breadcrumb showing different page title

image.png

@saragunnarsson saragunnarsson added the BTR Business Transparency Register label Nov 28, 2024
@mstanton1 mstanton1 added bug Something isn't working Priority1 labels Nov 29, 2024
@mstanton1
Copy link
Collaborator

If breadcrumbs are particularly challenging those could be pulled into another ticket.

@BrandonSharratt BrandonSharratt self-assigned this Dec 2, 2024
@BrandonSharratt
Copy link
Collaborator

This is not currently reproducible in any business in dev, and we unintentionally fixed the case in test by simply saving the application again. It looks to be the legal type was not present in the filing information. Please try to reproduce and we will look into it again.

For Devs - the issue likely stems from the businessBootsrap store line 15
const bootstrapLegalType = computed(() => bootstrapFiling.value?.filing.business.legalType )

@saragunnarsson
Copy link
Collaborator Author

Looks good! moving to QA

@BrandonSharratt
Copy link
Collaborator

Taking back as Sara found another case that breaks in test
https://business-dashboard-test.web.app/T3xsKCYb6g

this was filed today so something is making these malformed filings

@saragunnarsson
Copy link
Collaborator Author

Checked a bunch of different draft applications..seems to be working (but it's hard to know how to find the ones with issues since it seems a little random). Moving to QA.

@gunanagar
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BTR Business Transparency Register bug Something isn't working Priority1
Projects
None yet
Development

No branches or pull requests

4 participants