Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAY-JOBS - Consider credits when mailing out amounts that will be withdrawn from bank #19182

Closed
seeker25 opened this issue Jan 9, 2024 · 4 comments
Assignees
Labels
Pay Work for Pay Team

Comments

@seeker25
Copy link
Collaborator

seeker25 commented Jan 9, 2024

Credit applying to invoices runs at 8 PM PST, runs for 1 minute
Invoice creation happens at 6 PM PST
if we change the invoice creation job, split it so it sends out a notification at 9pm, instead of 6pm
it can query CAS for the amount_due and detect if there is a credit or not
so lets say there is a $100 invoice, with a $30 credit, it will take out $70 from the client's account
but email out $100 right now
hopefully if we change it to 9 pm, it will probably fix that issue

Edit: Not taking this approach, using credits table

@seeker25 seeker25 added the Pay Work for Pay Team label Jan 9, 2024
@seeker25 seeker25 changed the title PAY-JOBS - Potentially move invoice email outs after the credit applying job runs to provide total - credits as the amount to be taken from a client's bank account PAY-JOBS - Potentially move invoice email outs after the credit applying job runs to provide total - applied credits as the amount to be taken from a client's bank account Jan 9, 2024
@seeker25 seeker25 changed the title PAY-JOBS - Potentially move invoice email outs after the credit applying job runs to provide total - applied credits as the amount to be taken from a client's bank account PAY-JOBS - Move invoice email outs after the credit applying job runs to provide total - applied credits as the amount to be taken from a client's bank account Jan 25, 2024
@JohnamLane
Copy link
Collaborator

Hey team! Please add your planning poker estimate with Zenhub @Jxio @ochiu @rodrigo-barraza @seeker25

@JohnamLane JohnamLane removed the On Hold label Oct 2, 2024
@seeker25 seeker25 added On Hold and removed On Hold labels Oct 2, 2024
@seeker25 seeker25 self-assigned this Oct 9, 2024
@seeker25
Copy link
Collaborator Author

Looked at payment_account.credits but that's real time, will have to resort to using credits.remaining_amount subtract that from the total

@seeker25
Copy link
Collaborator Author

PR is up
Just verifying some data now, to make sure this is going to work

@seeker25 seeker25 changed the title PAY-JOBS - Move invoice email outs after the credit applying job runs to provide total - applied credits as the amount to be taken from a client's bank account PAY-JOBS - Consider credits when mailing out amounts that will be withdrawn from bank Oct 21, 2024
@seeker25
Copy link
Collaborator Author

seeker25 commented Nov 5, 2024

image.png

@PCC199 PCC199 closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pay Work for Pay Team
Projects
None yet
Development

No branches or pull requests

3 participants