From 4dace97c996ef0f285782849b6ea701b696d0bd3 Mon Sep 17 00:00:00 2001
From: Peinan Wang <peinanwang@RiddleMBP.local>
Date: Mon, 25 Nov 2024 18:15:01 -0800
Subject: [PATCH] PR update

---
 src/components/bcros/Divider.vue              |  2 +-
 .../bcros/filing/common/FiledLabel.vue        | 47 ++++++++++---------
 .../bcros/filing/common/filedAnd/Paid.vue     |  2 +-
 .../filing/common/filedAnd/PendingCoa.vue     |  6 +--
 .../filing/common/filedAnd/PendingPaid.vue    |  4 +-
 .../bcros/filing/common/filedAnd/Rejected.vue |  4 +-
 .../filing/common/futureEffective/Paid.vue    |  4 +-
 .../bcros/filing/item/StaffFiling.vue         |  6 +--
 src/components/bcros/pending/Item.vue         |  4 +-
 .../todo/content/ApprovedContinuationIn.vue   |  4 +-
 .../bcros/todo/content/ChangeRequested.vue    |  4 +-
 src/components/bcros/todo/content/Error.vue   |  4 +-
 src/components/bcros/todo/content/Paid.vue    |  4 +-
 src/components/bcros/todo/content/Pending.vue |  4 +-
 src/components/bcros/tooltip/Date.vue         |  2 +-
 src/lang/en.json                              |  4 ++
 16 files changed, 55 insertions(+), 50 deletions(-)

diff --git a/src/components/bcros/Divider.vue b/src/components/bcros/Divider.vue
index aa87fb5d..05b8c476 100644
--- a/src/components/bcros/Divider.vue
+++ b/src/components/bcros/Divider.vue
@@ -1,3 +1,3 @@
 <template>
-  <span class="mt-[0.1rem] mx-[0.5rem] h-4 border-l border-gray-600" />
+  <span class="h-4 border-l border-gray-600" />
 </template>
diff --git a/src/components/bcros/filing/common/FiledLabel.vue b/src/components/bcros/filing/common/FiledLabel.vue
index 59cba850..38dcc6eb 100644
--- a/src/components/bcros/filing/common/FiledLabel.vue
+++ b/src/components/bcros/filing/common/FiledLabel.vue
@@ -1,26 +1,29 @@
 <template>
-  <div class="filed-label d-inline">
-    <template v-if="isTypeStaff && putBackOnOrAdminDissolution">
-      <span>
-        {{ capitalizedFiledBy }} {{ filing.submitter }} {{ $t('text.filing.on') }}
-        <BcrosTooltipDate :date="filing.submittedDate" />
-      </span>
-    </template>
-
-    <template v-else>
-      <div class="flex flex-row gap-2 w-full">
-        <span>
-          ({{ $t('text.filing.filedBy') }} {{ filing.submitter }} {{ $t('text.filing.on') }}
-          <BcrosTooltipDate :date="filing.submittedDate" />)
-        </span>
-        <UDivider v-if="showEffectiveAs" orientation="vertical" :ui="{ border: { base: 'border-gray-600'} }" />
-        <span v-if="showEffectiveAs">
-          {{ $t('text.filing.effectiveAsOf').toString() }}
-          <BcrosTooltipDate :date="filing.effectiveDate" />
-        </span>
-      </div>
-    </template>
-  </div>
+  <template v-if="isTypeStaff">
+    <span v-if="putBackOnOrAdminDissolution">
+      ({{ $t('text.filing.filedBy') }} {{ filing.submitter }} {{ $t('text.filing.on') }}
+      <BcrosTooltipDate :date="filing.submittedDate" />)
+      <BcrosDivider class="ml-1 mr-2" />
+      {{ $t('text.filing.effectiveAsOf').toString() }}
+      <BcrosTooltipDate :date="filing.effectiveDate" />
+    </span>
+    <span v-else>
+      {{ capitalizedFiledBy }} {{ filing.submitter }} {{ $t('text.filing.on') }}
+      <BcrosTooltipDate :date="filing.submittedDate" />
+    </span>
+  </template>
+
+  <template v-else>
+    <span>
+      ({{ $t('text.filing.filedBy') }} {{ filing.submitter }} {{ $t('text.filing.on') }}
+      <BcrosTooltipDate :date="filing.submittedDate" />)
+    </span>
+    <span v-if="showEffectiveAs">
+      <BcrosDivider class="ml-1 mr-2" />
+      {{ $t('text.filing.effectiveAsOf').toString() }}
+      <BcrosTooltipDate :date="filing.effectiveDate" />
+    </span>
+  </template>
 </template>
 
 <script setup lang="ts">
diff --git a/src/components/bcros/filing/common/filedAnd/Paid.vue b/src/components/bcros/filing/common/filedAnd/Paid.vue
index e6428a42..f74ccf78 100644
--- a/src/components/bcros/filing/common/filedAnd/Paid.vue
+++ b/src/components/bcros/filing/common/filedAnd/Paid.vue
@@ -1,5 +1,5 @@
 <template>
-  <div class="break-words">
+  <div>
     <span>{{ $t('text.filing.filedAndPaid') }}</span>
     <BcrosFilingCommonFiledLabel :filing="filing" />
   </div>
diff --git a/src/components/bcros/filing/common/filedAnd/PendingCoa.vue b/src/components/bcros/filing/common/filedAnd/PendingCoa.vue
index d8bda8d8..1824c305 100644
--- a/src/components/bcros/filing/common/filedAnd/PendingCoa.vue
+++ b/src/components/bcros/filing/common/filedAnd/PendingCoa.vue
@@ -1,9 +1,9 @@
 <template>
   <div class="flex flex-col gap-1 items-start w-full">
-    <div class="break-words">
+    <span>
       {{ $t('text.filing.filedAndPending') }}
       <BcrosFilingCommonFiledLabel :filing="filing" />
-    </div>
+    </span>
     <BcrosTooltip
       :text="tooltipText"
       :popper="{
@@ -29,7 +29,7 @@ const props = defineProps({
 const effectiveDateTime = computed((): string =>
   props.filing.effectiveDate
     ? dateToPacificDateTime(new Date(props.filing.effectiveDate))
-    : `[${t('tooltip.filing.coaFileAndPendingPart2')}]`
+    : '[unknown]'
 )
 
 const tooltipText = computed(() =>
diff --git a/src/components/bcros/filing/common/filedAnd/PendingPaid.vue b/src/components/bcros/filing/common/filedAnd/PendingPaid.vue
index f5654fc9..edd868f7 100644
--- a/src/components/bcros/filing/common/filedAnd/PendingPaid.vue
+++ b/src/components/bcros/filing/common/filedAnd/PendingPaid.vue
@@ -1,9 +1,9 @@
 <template>
-  <div class="break-words">
+  <div>
     <span class="text-orange-500">
       {{ $t('text.filing.filedAndPending') }}
     </span>
-    <BcrosDivider />
+    <BcrosDivider class="ml-1 mr-2" />
     {{ $t('text.filing.paid') }}
     <BcrosFilingCommonFiledLabel :filing="filing" />
   </div>
diff --git a/src/components/bcros/filing/common/filedAnd/Rejected.vue b/src/components/bcros/filing/common/filedAnd/Rejected.vue
index 5aa1d054..33ec047f 100644
--- a/src/components/bcros/filing/common/filedAnd/Rejected.vue
+++ b/src/components/bcros/filing/common/filedAnd/Rejected.vue
@@ -1,9 +1,9 @@
 <template>
-  <div class="break-words">
+  <div>
     <span class="text-orange-500 font-bold">
       {{ $t('text.filing.rejected') }}
     </span>
-    <BcrosDivider />
+    <BcrosDivider class="ml-1 mr-2" />
     <span>
       {{ $t('text.filing.submittedBy') }} {{ filing.submitter }} {{ $t('text.filing.on') }}
     </span>
diff --git a/src/components/bcros/filing/common/futureEffective/Paid.vue b/src/components/bcros/filing/common/futureEffective/Paid.vue
index 6cc42273..09fa7693 100644
--- a/src/components/bcros/filing/common/futureEffective/Paid.vue
+++ b/src/components/bcros/filing/common/futureEffective/Paid.vue
@@ -1,5 +1,5 @@
 <template>
-  <div class="break-words">
+  <div>
     <span v-if="isTypeIncorporationApplication">{{ $t('text.filing.futureEffectiveIncorporation') }}</span>
     <span v-else-if="isTypeContinuationApplication">{{ $t('text.filing.futureEffectiveContinuation') }}</span>
     <span v-else-if="isTypeAlteration">{{ $t('text.filing.futureEffectiveAlteration') }}</span>
@@ -8,7 +8,7 @@
     <span>
       {{ $t('text.filing.paid') }}
     </span>
-    <BcrosDivider />
+    <BcrosDivider class="ml-1 mr-2" />
     <BcrosFilingCommonFiledLabel :filing="filing" />
   </div>
 </template>
diff --git a/src/components/bcros/filing/item/StaffFiling.vue b/src/components/bcros/filing/item/StaffFiling.vue
index f8cbc79e..fe510622 100644
--- a/src/components/bcros/filing/item/StaffFiling.vue
+++ b/src/components/bcros/filing/item/StaffFiling.vue
@@ -9,10 +9,8 @@
     </template>
 
     <template #subtitle>
-      <div class="flex flex-row gap-1 w-full">
-        <span v-if="putBackOnOrAdminDissolution">{{ $t('text.filing.filed') }}</span>
-        <BcrosFilingCommonFiledLabel :filing="filing" />
-      </div>
+      <span v-if="putBackOnOrAdminDissolution">{{ $t('text.filing.filed') }}</span>
+      <BcrosFilingCommonFiledLabel :filing="filing" />
     </template>
 
     <template #body>
diff --git a/src/components/bcros/pending/Item.vue b/src/components/bcros/pending/Item.vue
index bf554e7a..3c596651 100644
--- a/src/components/bcros/pending/Item.vue
+++ b/src/components/bcros/pending/Item.vue
@@ -35,9 +35,9 @@ const expanded = ref(true)
             </span>
           </UButton>
         </div>
-        <div class="break-words">
+        <div>
           <span>PENDING STAFF REVIEW</span>
-          <BcrosDivider />
+          <BcrosDivider class="ml-1 mr-2" />
           <span>Submitted by {{ item.submitter }} on</span>
           <BcrosTooltipDate :date="item.submittedDate" />
         </div>
diff --git a/src/components/bcros/todo/content/ApprovedContinuationIn.vue b/src/components/bcros/todo/content/ApprovedContinuationIn.vue
index 549838b9..d3d13150 100644
--- a/src/components/bcros/todo/content/ApprovedContinuationIn.vue
+++ b/src/components/bcros/todo/content/ApprovedContinuationIn.vue
@@ -11,9 +11,9 @@ const { linkedNr } = storeToRefs(useBcrosBusinessBootstrap())
   <div
     class="flex flex-col gap-2 items-start"
   >
-    <div class="break-words">
+    <div>
       <span>Continuation Authorization APPROVED</span>
-      <BcrosDivider />
+      <BcrosDivider class="ml-1 mr-2" />
       <span>Submitted by {{ todoItem.submitter }} on</span>
       <BcrosTooltipDate :date="dateToString(todoItem.submittedDate)" />
     </div>
diff --git a/src/components/bcros/todo/content/ChangeRequested.vue b/src/components/bcros/todo/content/ChangeRequested.vue
index 133d356e..78baa985 100644
--- a/src/components/bcros/todo/content/ChangeRequested.vue
+++ b/src/components/bcros/todo/content/ChangeRequested.vue
@@ -11,11 +11,11 @@ const { linkedNr } = storeToRefs(useBcrosBusinessBootstrap())
   <div
     class="flex flex-col gap-2 items-start"
   >
-    <div class="break-words">
+    <div>
       <span class="text-orange-500 font-bold">
         {{ $t('text.todoItem.changeRequested') }}
       </span>
-      <BcrosDivider />
+      <BcrosDivider class="ml-1 mr-2" />
       <span>
         Submitted by {{ todoItem.submitter }} on <BcrosTooltipDate :date="dateToString(todoItem.submittedDate)" />
       </span>
diff --git a/src/components/bcros/todo/content/Error.vue b/src/components/bcros/todo/content/Error.vue
index 61dc72e2..2ff08638 100644
--- a/src/components/bcros/todo/content/Error.vue
+++ b/src/components/bcros/todo/content/Error.vue
@@ -7,9 +7,9 @@ defineProps({
 
 <template>
   <!-- error filing -->
-  <div class="break-words">
+  <div>
     <span>{{ $t('text.todoItem.status.pending') }}</span>
-    <BcrosDivider />
+    <BcrosDivider class="ml-1 mr-2" />
     <span v-if="inProcessFiling === todoItem.filingId">{{ $t('text.todoItem.status.processing') }}...</span>
     <span v-else>{{ $t('text.todoItem.status.paymentIncomplete') }}</span>
   </div>
diff --git a/src/components/bcros/todo/content/Paid.vue b/src/components/bcros/todo/content/Paid.vue
index e8e93cd1..2d8b9bc7 100644
--- a/src/components/bcros/todo/content/Paid.vue
+++ b/src/components/bcros/todo/content/Paid.vue
@@ -7,9 +7,9 @@ defineProps({
 
 <template>
   <!-- paid filing -->
-  <div class="break-words">
+  <div>
     <span>{{ $t('text.todoItem.status.pending') }}</span>
-    <BcrosDivider />
+    <BcrosDivider class="ml-1 mr-2" />
     <span v-if="inProcessFiling === todoItem.filingId">{{ $t('text.todoItem.status.processing') }}...</span>
     <span v-else>{{ $t('text.todoItem.status.paid') }}</span>
   </div>
diff --git a/src/components/bcros/todo/content/Pending.vue b/src/components/bcros/todo/content/Pending.vue
index ceea8907..6b70be60 100644
--- a/src/components/bcros/todo/content/Pending.vue
+++ b/src/components/bcros/todo/content/Pending.vue
@@ -20,9 +20,9 @@ defineProps({
       <span v-else>{{ $t('text.todoItem.status.pending') }}</span>
     </template>
 
-    <div v-else class="break-words">
+    <div v-else>
       <span>{{ $t('text.todoItem.status.pending') }}</span>
-      <BcrosDivider />
+      <BcrosDivider class="ml-1 mr-2" />
       <span v-if="inProcessFiling === todoItem.filingId">{{ $t('text.todoItem.status.processing') }}...</span>
       <span v-else-if="todoItem.paymentMethod === PaymentMethodE.ONLINE_BANKING">
         {{ $t('text.todoItem.status.pendingOnlineBanking') }}
diff --git a/src/components/bcros/tooltip/Date.vue b/src/components/bcros/tooltip/Date.vue
index 8173052a..e77bb75f 100644
--- a/src/components/bcros/tooltip/Date.vue
+++ b/src/components/bcros/tooltip/Date.vue
@@ -6,7 +6,7 @@
       arrow: true
     }"
   >
-    <span class="font-13 ml-1 underline decoration-dotted break-words">
+    <span class="font-13 underline decoration-dotted">
       {{ dateToPacificDate(displayDate) }}
     </span>
   </BcrosTooltip>
diff --git a/src/lang/en.json b/src/lang/en.json
index 6faed4ec..c16d407c 100644
--- a/src/lang/en.json
+++ b/src/lang/en.json
@@ -281,6 +281,10 @@
         "title": "File Address Change",
         "draftTitle": "Address Change"
       },
+      "directorChange": {
+        "title": "File Director Change",
+        "draftTitle": "Director Change"
+      },
       "changeRequested": "CHANGE REQUESTED",
       "status": {
         "draft": "DRAFT",