Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass ask arg from cded_*() to vrt() #147

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Pass ask arg from cded_*() to vrt() #147

merged 2 commits into from
Oct 21, 2024

Conversation

ateucher
Copy link
Collaborator

In each of the cded_() functions, the ask argument was not passed on to the call to vrt(), as it was hard-coded to interactive(). This keeps the default as interactive() in the user-facing call and respects that in the call to vrt()

Copy link
Collaborator

@boshek boshek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for adding all the white space? Just messes with the git history a bit.

@ateucher
Copy link
Collaborator Author

Any reason for adding all the white space? Just messes with the git history a bit.

It's removing trailing whitespace (not adding any) - I'm trying to use more auto-formatting tools so I enabled this setting in Positron

@boshek
Copy link
Collaborator

boshek commented Oct 21, 2024

Right my bad. I think it is totally fine here (hence the approval) but my only slight nit is that it muddies the git history of the NEWS file a little. But not worth revert here. Thanks for this!

@ateucher ateucher merged commit c515f75 into main Oct 21, 2024
6 checks passed
@ateucher ateucher deleted the pass-ask-cded branch October 21, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants