Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revocation content missing from Revoked Credential Details #965

Closed
nodlesh opened this issue Mar 9, 2023 · 5 comments
Closed

Revocation content missing from Revoked Credential Details #965

nodlesh opened this issue Mar 9, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@nodlesh
Copy link
Contributor

nodlesh commented Mar 9, 2023

Bug:
missing (i) icon next to revocation status. This (i) icon opens the revocation message
Missing content at the bottom of the screen like revocation message and precise revocation date

Fix:
Design fixes. See new Acceptance Criteria below and wireframes

Acceptance Criteria

[from ticket #63]

Given a credential has been revoked
When the holder goes to the [revoked credential details](https://xd.adobe.com/view/615be678-5184-40cc-ab24-11a379a51233-3408/)
Then they will see a dismissible notification at the top displaying the revocation date and revocation message by the issuer
And they will see a revocation status below the issued date in the credential details

Given a credential has been revoked
When the [holder dismisses the dismissible notifications](https://xd.adobe.com/view/615be678-5184-40cc-ab24-11a379a51233-3408/screen/47fbeddd-9b8b-45f4-bb6f-73635d131306/) at the top displaying the revocation date and revocation message by the issuer
Then that notification is permanently dismissed and can not be brought back again

Wireframes

Revocation message in credential detail screen

Screenshots of build 732

Screenshot 2023-03-09 at 5.06.17 PM.png

Environment

BC Wallet build 732
Tested on Android 11

Workaround

None known

Severity

Medium

Priority

Medium

Test Impact

T011.1-Proof, T011.2-Proof

@nodlesh nodlesh added the bug Something isn't working label Mar 9, 2023
@knguyenBC
Copy link

Ticket updated with wireframes and link to acceptance criteria of existing revocation ticket.

@cvarjao
Copy link
Member

cvarjao commented Apr 27, 2023

@knguyenBC, please update acceptance criteria and wireframes

@bryce-mcmath
Copy link
Contributor

@knguyenBC is this ticket ready to go now?

@bryce-mcmath bryce-mcmath self-assigned this May 3, 2023
@knguyenBC
Copy link

I've updated the ticket to include the changes as discussed with the team: removed the need to invoke another notification pop up. The revocation status is permanent and contains both the revocation message and date of revocation. The notification at the top is dismissible once and cannot be brought back again.

@bryce-mcmath bryce-mcmath changed the title Revocation Status clickable Info icon missing from Revoked Credential Details Revocation content missing from Revoked Credential Details May 4, 2023
@nodlesh
Copy link
Contributor Author

nodlesh commented Jul 19, 2023

This is working as designed in build 1077.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants