Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDN call to JQuery - necessary? #9

Open
Gavin-McLeod opened this issue Mar 27, 2017 · 1 comment
Open

CDN call to JQuery - necessary? #9

Gavin-McLeod opened this issue Mar 27, 2017 · 1 comment

Comments

@Gavin-McLeod
Copy link
Contributor

I see that although the bootstrap library is made local to the project (/js/bootstrap.js and /js/bootstrap.min.js), the same is not true of the JQuery library. The sample HTML are calling the JQuery library from a CDN (https://ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js).

It's easy enough to call JQuery from a local location per project or per organization, but I wonder if there is a particular reason for this? This won't be acceptable for production code.

@juhewitt
Copy link
Collaborator

Yup, I'm down with including the core jQuery library rather than linking externally. Can you do a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants