Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: param for triggers_event, default to pull_request #36

Merged
merged 14 commits into from
Aug 29, 2023
Merged

feat: param for triggers_event, default to pull_request #36

merged 14 commits into from
Aug 29, 2023

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Aug 29, 2023 •
edited
Loading

New parameter for limiting triggers to a specific set of event types. Default = ("pull_request").

This allows triggers to be used on non-PRs, like push or workflow_dispatch.

@DerekRoberts DerekRoberts self-assigned this Aug 29, 2023
@DerekRoberts DerekRoberts added the enhancement New feature or request label Aug 29, 2023
@DerekRoberts DerekRoberts marked this pull request as ready for review August 29, 2023 02:47
@DerekRoberts DerekRoberts force-pushed the feat/disableTriggersOffPRs branch from 5017345 to a814f01 Compare August 29, 2023 02:48
@DerekRoberts DerekRoberts force-pushed the feat/disableTriggersOffPRs branch from a814f01 to 1df2c44 Compare August 29, 2023 02:58
@DerekRoberts DerekRoberts changed the title feat: limit triggers to PRs, default=true feat: param for triggers_event, default to pull_request Aug 29, 2023
@DerekRoberts DerekRoberts force-pushed the feat/disableTriggersOffPRs branch from d0d7aea to 0587ef8 Compare August 29, 2023 04:26
@DerekRoberts DerekRoberts linked an issue Aug 29, 2023 that may be closed by this pull request
feat: base triggers on events #37
Closed
mishraomp
mishraomp approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

@DerekRoberts DerekRoberts merged commit 4b38a70 into main Aug 29, 2023
@DerekRoberts DerekRoberts deleted the feat/disableTriggersOffPRs branch August 29, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishraomp mishraomp mishraomp approved these changes

@paulushcgcj paulushcgcj Awaiting requested review from paulushcgcj

Assignees

@DerekRoberts DerekRoberts

Labels
enhancement New feature or request
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: base triggers on events
2 participants
@DerekRoberts @mishraomp