Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endianness character present in .zattr for single byte data types #25

Closed
grlee77 opened this issue Apr 26, 2021 · 2 comments
Closed

endianness character present in .zattr for single byte data types #25

grlee77 opened this issue Apr 26, 2021 · 2 comments

Comments

@grlee77
Copy link

grlee77 commented Apr 26, 2021

cc @joshmoore

While running a branch of zarr_implementations with jzarr-based read/write tests (with jzarr 0.3.2), I encountered the following issue.

The data used in the example in that repository has an 8-bit unsigned integer format. The .zattr JSON files created by jzarr currently have the following entry

"dtype" : ">u1",

but .zattr files created by other libraries such as zarr-python, xtensor-zarr and z5py have:

"dtype" : "|u1",

It seems that the spec indicates that | should be used rather than > or < for data types with a single byte width where there is no endianness. A similar issue may also be present for |b1 and |i1 types, but I have not confirmed that.

@joshmoore
Copy link

Failing builds can be found in zarr-developers/zarr_implementations#37

@SabineEmbacher
Copy link
Collaborator

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants