Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: attributeNames does not support MessageSystemAttributeName #486

Closed
leovvay opened this issue Apr 23, 2024 · 3 comments
Closed

[Bug]: attributeNames does not support MessageSystemAttributeName #486

leovvay opened this issue Apr 23, 2024 · 3 comments

Comments

@leovvay
Copy link

leovvay commented Apr 23, 2024

Describe the bug

currently attributes name have a type definition of QueueAttributeName https://github.com/bbc/sqs-consumer/blob/main/src/types.ts#L15C3-L15C17, and missing MessageSystemAttributeName from clinet-sqs, which is actually supported by attributeNames with attributeNames: ['MessageGroupId', 'SentTimestamp'] as any, bypass

Your minimal, reproducible example

Consumer.create with attributeNames: ['MessageGroupId', 'SentTimestamp']

Steps to reproduce

  1. create a consumer via Consumer.create with attributeNames: ['MessageGroupId', 'SentTimestamp']
  2. observer type error
  3. change to attributeNames: ['MessageGroupId', 'SentTimestamp'] as any
  4. observer MessageGroupId actually received with this attribute names

Expected behavior

attributeNames type should support MessageSystemAttributeName from @aws-sdk/client-sqs

How often does this bug happen?

None

Screenshots or Videos

No response

Platform

macOs 14.4.1

Package version

v9.1.0

AWS SDK version

"@aws-sdk/client-sqs": "^3.556.0",

Additional context

No response

@nicholasgriffintn
Copy link
Member

AWS' SQS SDK sets the type for attributes as QueueAttributeName https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/client/sqs/command/ReceiveMessageCommand/.

So it should be updated their side as this is made to match what the SDK actually sets as its expectation.

@nicholasgriffintn
Copy link
Member

Update: I've actually found a related issue here: aws/aws-sdk-js-v3#5403 so that might be one to follow.

Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants