Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At 200% zoom, broken underline on Read about our approach text in the Footer #863

Closed
jtart opened this issue Oct 29, 2018 · 5 comments
Closed
Labels
a11y Accessibility-related task bug Something isn't working ws-articles Tasks for the WS Articles Team

Comments

@jtart
Copy link
Contributor

jtart commented Oct 29, 2018

Describe the bug
When the page is zoomed in to 200%, in Chrome at some breakpoints - When you hover/focus on ‘Read about our approach…’ the underline covers some of the text.

This issue can also be seen on iPhone 5 when using VoiceOver (some users use a keyboard with a mobile device).

To Reproduce
View on Chrome in desktop, and on iPhone 5, view a page at 200% zoom, and view the underline covering some of the text in the Read about our approach... in the Footer.

Expected behaviour
Underline should not cover text, likely should discuss with UX about how it should look.

Desktop (please complete the following information):

  • Chrome

Smartphone (please complete the following information):

  • iPhone 5
@jtart jtart added bug Something isn't working a11y Accessibility-related task Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. labels Oct 29, 2018
@jtart jtart added this to the 02. News Footer milestone Oct 29, 2018
@BogdanDogaru
Copy link
Contributor

BogdanDogaru commented Nov 1, 2018

Blocked on #828 and #616

@BogdanDogaru BogdanDogaru added blocked This issue should not be worked on until another internal issue is completed - see desc for details and removed Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. labels Nov 1, 2018
@jamesbhobbs jamesbhobbs removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Mar 21, 2019
@sareh
Copy link
Contributor

sareh commented Apr 9, 2019

Still valid issue:

Screen Shot of footer with 200% zoom
Screen Shot of footer with 200% zoom

Note: even without zooming, if you have a small viewport, the underline overlaps the text below:

Screen Shot of footer with 100% zoom, in a small viewport (which allows link to flow over multiple lines)
Screen Shot of footer with 100% zoom

Should be raised with @nataliesmart from UX.

@sareh sareh removed the alpha-3 label Apr 9, 2019
@sareh
Copy link
Contributor

sareh commented Apr 9, 2019

As a result of discussing with @greenc05 & @nataliesmart, it was discussed to change the hover/focus to use text-decoration: underline instead of the border bottom.

Here's the impact of before/after when changing this in the browser:

Current implementation with border-bottom:
Screen Shot 2019-04-09 at 13 16 20
Screen Shot 2019-04-09 at 13 19 46

With text-decoration: underline
Screen Shot 2019-04-09 at 13 16 41
Screen Shot 2019-04-09 at 13 15 56

@sareh sareh added ws-articles Tasks for the WS Articles Team simorgh-core-stream labels Apr 9, 2019
@sareh
Copy link
Contributor

sareh commented Apr 9, 2019

Added label simorgh-core-stream since all front-end components that are shared between Articles and Front Pages are to be addressed by Simorgh Core.

@jamesbhobbs
Copy link
Contributor

Covered here BBC-archive/psammead#397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility-related task bug Something isn't working ws-articles Tasks for the WS Articles Team
Projects
None yet
Development

No branches or pull requests

4 participants