Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the amount of data/props we send to page components #7153

Open
1 task
jroebu14 opened this issue Jul 6, 2020 · 0 comments
Open
1 task

Reduce the amount of data/props we send to page components #7153

jroebu14 opened this issue Jul 6, 2020 · 0 comments
Labels
cross-team For visibility for both World Service teams (Engage & Media) performance Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. technical-work Technical debt, support work and building new technical tools and features

Comments

@jroebu14
Copy link
Contributor

jroebu14 commented Jul 6, 2020

Is your feature request related to a problem? Please describe.
If you look at view-source:https://www.bbc.com/japanese and look at the window.SIMORGH_DATA json you will see this resembles a lot of the data fetched from Ares which is roughly 65kb in total for this page. This is for the React SPA hydration on the client which is the data created in getInitialData in each route.

There is potential for page weight savings by plucking out only the data we need before sending to the page component.

Describe the solution you'd like
We should not over-provide our page components with data.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Similar issues:
#4476
#3962
#3003

@jroebu14 jroebu14 added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. technical-work Technical debt, support work and building new technical tools and features labels Jul 6, 2020
@karinathomasbbc karinathomasbbc added the cross-team For visibility for both World Service teams (Engage & Media) label Jul 21, 2020
@joshcoventry joshcoventry added this to the Frontend Web Performance milestone Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-team For visibility for both World Service teams (Engage & Media) performance Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. technical-work Technical debt, support work and building new technical tools and features
Projects
None yet
Development

No branches or pull requests

3 participants