Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Footer for Afaan Oromoo Page #3034

Closed
aeroplanejane opened this issue Aug 9, 2019 · 3 comments · Fixed by #3091 or BBC-archive/psammead#1731
Closed

Enable Footer for Afaan Oromoo Page #3034

aeroplanejane opened this issue Aug 9, 2019 · 3 comments · Fixed by #3091 or BBC-archive/psammead#1731
Assignees
Labels
ws-media World Service Media

Comments

@aeroplanejane
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We require the footer to be enabled for Afaan Oromoo with the correct translations and correct links

Please refer to the full spec in WSMEDIA-29 (linked to confluence translations is included)

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

Additional context
Add any other context or screenshots about the feature request here.

@aeroplanejane aeroplanejane added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-media World Service Media labels Aug 9, 2019
@ryanmccombe ryanmccombe self-assigned this Aug 12, 2019
@ryanmccombe ryanmccombe removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Aug 12, 2019
@ryanmccombe
Copy link
Contributor

Added footer:

Screen Shot 2019-08-12 at 14 58 33

Some notes:

  • Fonts still wrong - worked on by another pod
  • We only have 4 translated links for afaan oromoo? Standard simorgh config has 6 - I removed the "About Us" and "Accessibility Help" links from the standard config. The current afaan oromoo page seems to have 8 links
  • I added full stops to the end of copyright text and and external link text. ACs didn't have them, but they do seem to be standard in the current pages and the designs
  • There is a full stop missing between the copyright text and external link text in the footer component. I didn't fix this - it's a cross cutting component and this bug is currently in production like this (bbc.com/igbo)

Let me know if any of this needs changed @aeroplanejane

@aeroplanejane
Copy link
Contributor Author

@ryanmccombe Can you just ensure there's a space after the full stop on the copyright line? You can refer to the designs here, thanks! https://app.zeplin.io/project/5d4d77b1fcbfc79bf47e0294/screen/5d4d781442322e35280307a5

@ryanmccombe
Copy link
Contributor

The layout is in Psammead - created this PR to add it: BBC-archive/psammead#1731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ws-media World Service Media
Projects
None yet
2 participants