Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never italicise Farsi #2618

Closed
1 task
twinlensreflex opened this issue Jul 18, 2019 · 2 comments
Closed
1 task

Never italicise Farsi #2618

twinlensreflex opened this issue Jul 18, 2019 · 2 comments
Labels
ws-articles Tasks for the WS Articles Team

Comments

@twinlensreflex
Copy link
Contributor

twinlensreflex commented Jul 18, 2019

Is your feature request related to a problem? Please describe.
replaced PR 2548, see discussion on PR for why
We want to use psammead-font-styles across Simorgh to ensure that we are not italicising Farsi.

Describe the solution you'd like

Describe alternatives you've considered
Fixing these issues by using

 [lang=fa] & {
    font-style: normal;
  }

but the approach in this ticket removes duplication and will handle this for more languages than just farsi.

Testing notes

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

Additional context
Add any other context or screenshots about the feature request here.

@twinlensreflex twinlensreflex added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-articles Tasks for the WS Articles Team articles-current-epic labels Jul 18, 2019
@twinlensreflex
Copy link
Contributor Author

Possibly can be closed on this work:
#2548
BBC-archive/psammead#376
#1731

@RayNjeri RayNjeri removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Jul 18, 2019
@twinlensreflex twinlensreflex changed the title Use @bbc/psammead-font-styles across simorgh Never italicise Farsi Jul 18, 2019
@twinlensreflex
Copy link
Contributor Author

I've updated #1731 with the information from this issye and will now close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ws-articles Tasks for the WS Articles Team
Projects
None yet
Development

No branches or pull requests

2 participants