Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storypromo to use latest psammead-media-indicator #2569

Closed
Bopchy opened this issue Jul 16, 2019 · 1 comment
Closed

Update storypromo to use latest psammead-media-indicator #2569

Bopchy opened this issue Jul 16, 2019 · 1 comment
Labels
Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test.

Comments

@Bopchy
Copy link

Bopchy commented Jul 16, 2019

Is your feature request related to a problem? Please describe.
BBC-archive/psammead#1240 removes the offscreen text prop from <MediaIndicator /> . Storypromo should be updated to not use the offscreenText prop

Describe the solution you'd like
Updating StoryPromo to use the latest version of MediaIndicator - that doesn't have the offscreenText prop

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

Additional context
Add any other context or screenshots about the feature request here.

@Bopchy Bopchy added the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Jul 16, 2019
@Bopchy
Copy link
Author

Bopchy commented Jul 16, 2019

Closed in favour of opening issue in Psammead

@Bopchy Bopchy closed this as completed Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test.
Projects
None yet
Development

No branches or pull requests

1 participant