Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove top & bottom padding inline links #1055

Closed
1 task done
pjlee11 opened this issue Dec 5, 2018 · 2 comments
Closed
1 task done

Remove top & bottom padding inline links #1055

pjlee11 opened this issue Dec 5, 2018 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@pjlee11
Copy link

pjlee11 commented Dec 5, 2018

Describe the bug
Following the investigate performed in #616 UX have confirmed we should remove the top and bottom padding from the inline link component.

To Reproduce
See screenshots and bug description on #616

Expected behaviour
See screenshots and bug description on #616

Additional context
This is the issue is related to both the caption text but also body text when it comes to multi-line links.

  • Initially labelled with "bug"
@sareh
Copy link
Contributor

sareh commented Dec 17, 2018

Closed since issue is now in Psammead: BBC-archive/psammead#222

@sareh sareh closed this as completed Dec 17, 2018
@dr3
Copy link

dr3 commented Jan 3, 2019

Reopened due to BBC-archive/psammead#222 not being possible without larger font changes. This work however is small enough to just do for its minor benifits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants